field item classes are consistently named FooItem, ShortcutPath should comply

CommentFileSizeAuthor
#8 shortcutitem-2175785-8.patch3.03 KByched
#6 interdiff-2175785-1-6.txt2.46 KBinternetdevels
#6 rename-shortcutpath-shortcutitem-shortcut-2175785-6.patch1.79 KBinternetdevels
#1 shortcutitem-2175785-1.patch1.48 KByched

Comments

yched’s picture

yched commented
Status: Active » Needs review
StatusFileSize
new shortcutitem-2175785-1.patch1.48 KB

Patch

Status: Needs review » Needs work

The last submitted patch, 1: shortcutitem-2175785-1.patch, failed testing.

amateescu’s picture

amateescu commented

Then we should do the same for Drupal\comment\CommentFieldName :)

yched’s picture

yched commented

[edit: crosspost ;-) ]

amateescu’s picture

amateescu commented

[edit: that crosspost was funny!]

internetdevels’s picture

internetdevels commented
Status: Needs work » Needs review
StatusFileSize
new rename-shortcutpath-shortcutitem-shortcut-2175785-6.patch1.79 KB
new interdiff-2175785-1-6.txt2.46 KB

The last submitted patch, 6: rename-shortcutpath-shortcutitem-shortcut-2175785-6.patch, failed testing.

yched’s picture

yched commented
StatusFileSize
new shortcutitem-2175785-8.patch3.03 KB

git diff & file renames...

dermario’s picture

dermario
Primary language German
Location Zürich
commented
Status: Needs review » Reviewed & tested by the community

I tested on my local machine. The patch applies to me and comment system works perfectly. I was able to create, delete and reply to a comment.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed d18bb47 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.