If I select multiple files to upload into multiple image or file field and one of the files won't pass validation it will break the widget display, though all valid files are uploaded. This also is broken for valid images.

image upload

When removing an image, this is also broken.

CommentFileSizeAuthor
#11 2172241-11.patch1.9 KBswentel
#11 2172241-11-fail.patch1.28 KBswentel
#10 2172241-10.patch643 bytesswentel
#9 image-widget-multiple-values.patch2.3 KBwebflo
#4 Screen Shot 2014-02-16 at 13.37.09.png50.47 KBswentel
fupload.png50.79 KBAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented
Issue summary: View changes
swentel’s picture

swentel commented
Version: 8.0-alpha7 » 8.x-dev

confirmed

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Title: Image not passing validation breaks widget » Files not passing validation breaks widget
Issue summary: View changes

Changing issue title and summary because I can reproduce the same problem in File widget, which is the Image's parent.

So I think the problem is in Filewidget instead of ImageWidget.

Regards

swentel’s picture

swentel commented
Title: Files not passing validation breaks widget » Files and image widgets completely broken
StatusFileSize
new Screen Shot 2014-02-16 at 13.37.09.png50.47 KB

The widgets are broken, also if If you upload valid files. Also clicking on 'Remove' when going back to edit a node, is completely broken

swentel’s picture

swentel commented
Issue summary: View changes
swentel’s picture

swentel commented
Issue summary: View changes
swentel’s picture

swentel commented
Priority: Normal » Major

Also, this is really major

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented

After digging in this issue for a while, these are my conclusions:

  • IMO, there are two different problems here:
    • File widget is broken when you try to upload multiple files at the same time and not all are valids
    • Image widget is broken when you uploads more than one image, even uploaded one bye one. Also when trying to remove an item through the "Remove" button.
  • I've been debugging the FileWidget bug firstly given that ImageWidget extends it. I think that the bug is due to the managed_file form element validation. Given that the validation fails, widget FileWidget::formElement() and FileWidget::formMultipleElements() are not called and the correct values are not processed properly.

I'll try to work more on this along the next week, but not sure about the right way to fix this, because it looks related to the managed_file form element behavior. I'll also try to take a look to the ImageWidget bug.

Regards

webflo’s picture

webflo commented
Status: Active » Needs review
StatusFileSize
new image-widget-multiple-values.patch2.3 KB

Looks like some ajax code from FileWidget::process is missing in ImageWidget::process

swentel’s picture

swentel commented
StatusFileSize
new 2172241-10.patch643 bytes

Ah nice find! Updated patch. By calling the parent function, the change is even smaller.

I'm really not sure whether we need a test for this ..

swentel’s picture

swentel commented
StatusFileSize
new 2172241-11-fail.patch1.28 KB
new 2172241-11.patch1.9 KB

Now with tests. First one will have 2 failes, second one passes.

The last submitted patch, 11: 2172241-11-fail.patch, failed testing.

fabianx’s picture

fabianx commented
Status: Needs review » Reviewed & tested by the community

RTBM - nice catch, regression of recent core patch

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

  • Commit e9bb4a2 on 8.x by Dries: 
    Issue #2172241 by swentel, webflo | ivanjaros: Fixed Files and image...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.