Code used to generate hash is hash('sha256', serialize($this->source)) results 64 chars

Also handbook page https://drupal.org/node/2129649 needs update about using hashes track_changes: true

CommentFileSizeAuthor
#2 migrate_hash-2.patch2.89 KBandypost
#1 migrate_hash-1.patch3.47 KBandypost
migrate_hash.patch1.08 KBandypost

Comments

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new migrate_hash-1.patch3.47 KB

Added test and fixed existing test

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new migrate_hash-2.patch2.89 KB

Proper place for test

chx’s picture

chx commented
Project: Drupal core » IMP
Version: 8.x-dev »
Component: migration system » Code
Status: Needs review » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

andyceo’s picture

andyceo commented
Project: IMP » Drupal core
Version: » 8.x-dev
Component: Code » migration system
Status: Closed (fixed) » Active

Should not this be fixed in core too?

chx’s picture

chx commented
Status: Active » Fixed

I think the rule is to commit breaks to core, so sure, although we didn't submit anything back cos we changed so much ... but, sure.

chx’s picture

chx commented
Status: Fixed » Reviewed & tested by the community

Drats, wrong status.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.