Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Currently there's no way to alter plugin definitions because MigratePluginManager does not use DefaultPluginManager::getDefinition()
| Comment | File | Size | Author |
|---|---|---|---|
| migrate_alter.patch | 1.01 KB | andypost | |
Comments
Comment #1
dawehnerI wonder whether we need a test for that?
Comment #2
chx CreditAttribution: chx commentedI somewhat doubt. Very nice catch, thanks andypost.
Comment #3
chx CreditAttribution: chx commentedTo elaborate: theoretically a test might be useful but I am afraid it'd take a lot of work to test that the plugin alteration works and it's not worth it. Usually we want a test to make sure we do not regress but regressing on this? That looks extremely unlikely.
Comment #4
andypostI think we have enough test coverage for
DefaultPluginManagerPS: to test this properly migrate needs test module with alter hook, not sure it makes sense to implement one to test default functionality
Comment #5
webchickHm. I really don't like committing bug fixes without tests, but basically chx/andypost have pointed out that the base plugin classes to contain test coverage for this, and if we added an alter test here it'd be a one-off for this single plugin type, which doesn't really make much sense. The bug was caused by a typo that's unlikely to be re-introduced.
So, with that, committed and pushed to 8.x. Thanks!