Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Steps to reproduce
- On a fresh install, login and go to admin/structure/block
- Ensure that the row weights are hidden (click 'Hide row weights' at the top right of the table if necessary)
- Rearrange the blocks in the 'sidebar first' region
This should update the weight fields (which you can see by clicking the 'Show row weights' link at the top right) and display a warning at the top of the page that your changes have not yet been saved. Because these fields have not been updated, if you save the page the new order will not be remembered. This doesn't only apply to the block page, it was just a convenient example of a tabledrag.
This is a regression caused by #1979468: ".active" from linkGenerator(), l() and theme_links() forces an upper limit of per-page caching for all content containing links. It was first spotted by jhodgdon.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | core-js-fix-tabledrag-2168233-2.patch | 1.47 KB | nod_ |
Comments
Comment #1
dawehnerThis is really critical.
Comment #2
nod_Drupal.attachBehaviorsandDrupal.detachBehaviorsexpect a single DOM object as the context argument. tabledrag was passing an array of jQuery objects.Comment #3
nod_Oh and before anyone notice, ajax.js does it wrong too.
Comment #4
nod_and since we're using
.forEach()tagging for ie8 module.Comment #5
nod_Forget #3, the patch to test and commit is #2.
someone did notice ajax.js before me :D \o/ #2168171: ajax.js passes context as jQuery object to attachBehaviors and detachBehaviors, should pass plain object
Comment #7
nod_parent has been rolled back, put this in new patch.