Updated: Comment #0

Problem/Motivation

While working on another issue, I discovered that some of \Drupal\system\Tests\Batch\ProcessingTest's tests contain broken tests: they call a helper function that contains expected messages with an incorrect parameter, and consequently they test if the empty string exists on the page, which is of course always true.

Proposed resolution

Fix + prevent this in the future.

Remaining tasks

None.

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#1 batch_broken_tests-2158259-1.patch2.02 KBwim leers

Comments

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new batch_broken_tests-2158259-1.patch2.02 KB

Status: Needs review » Needs work

The last submitted patch, 1: batch_broken_tests-2158259-1.patch, failed testing.

The last submitted patch, 1: batch_broken_tests-2158259-1.patch, failed testing.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review

1: batch_broken_tests-2158259-1.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Perfect, thank you!

chx’s picture

chx commented

The proposed resolution is

Fix + prevent this in the future.

but I see no prevention. Which should not block the commit of this but still some future proofing would be nice (especially since it has been proposed).

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Yes that's worth a normal follow-up for.

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.