Fix case of Datetime widgets and formatters

Looks good to me.

Yay, PHP!

Edit:

php -r 'class x {static function foo(){}} ; $x = X::fOO(); var_dump($X);'
PHP Notice: Undefined variable: X in Command line code on line 1


Classnames are case insensitive. Method names are case insensitive. Variable names, however, are case sensitive.

Yes, beware class properties, static properties and constants =)

50% of the DateTime classes were messed up like this, also tests. Simpletest didn't like that very much but those have been fixed already.

To my knowledge, the DateTime module and plugins were modeled after PHP's native DateTime class.

PHP's native class name is CamelCased; i.e., DateTime as opposed to Datetime.

Do we rather want to rename the filenames to use DateTime, too?

Good point, yes, we do.

Almost all other classes, with the exception of a single test are named DateTime...

I think this was changed at some point in the development of that patch/module and that messed this up...

@timplunkett: Must be tough live under such inhuman circumstances :)

I can't apply this because I'm on Mac:

$ git apply --index datetime-case-8.patch 
error: core/modules/datetime/lib/Drupal/datetime/Plugin/Field/FieldFormatter/DateTimeDefaultFormatter.php: already exists in working directory
error: core/modules/datetime/lib/Drupal/datetime/Plugin/Field/FieldFormatter/DateTimePlainFormatter.php: already exists in working directory
error: core/modules/datetime/lib/Drupal/datetime/Plugin/Field/FieldWidget/DateTimeDatelistWidget.php: already exists in working directory
error: core/modules/datetime/lib/Drupal/datetime/Plugin/Field/FieldWidget/DateTimeDefaultWidget.php: already exists in working directory

Tentatively trying alexpott?

8: datetime-case-8.patch queued for re-testing.

Committed 562b775 and pushed to 8.x. Thanks!