It is just killing me that the garland page.tpl.php doesn't have an id (or even a distinctive class) for the content div. The default page.tpl.php (in the modules/system folder) adds an id="content-content", which woudl make jQuery targeting much cleaner.

CommentFileSizeAuthor
#9 garland.patch765 bytesstarbow
#5 content_types.patch1.21 KBstarbow
#1 garland.patch765 bytesstarbow
garland.patch4.08 KBstarbow

Comments

starbow’s picture

starbow commented
Status: Active » Needs review
StatusFileSize
new garland.patch765 bytes

Oops, bogus patch.

dvessel’s picture

dvessel commented

How about something other than "garland-content"?

The default in "modules/system/page.tpl.php" uses "content-content" while still a little odd, I think it's better than using the theme's name. Or maybe just "main-content" would be fine.

starbow’s picture

starbow commented

I don't really care what the id is. The only thing is that it needs to be something no one in the world is already using as an id in their content (two id's with the same name in the same page is a no-no).

dvessel’s picture

dvessel commented
Status: Needs review » Needs work

Well, the rest of us do. With the coming of Drupal 7 we will try to standardize on ID's and classes. "garland-content" is guaranteed to be changed when that happens. It's not semantic. Period.

Choose a good ID now and there's less chance of it being changed, and anything depending on it also.

starbow’s picture

starbow commented
Status: Needs work » Needs review
StatusFileSize
new content_types.patch1.21 KB

Ok, since there has obviously been thought put into the page.tpl.php file in the system folder, I will assume 'content-content' is the right answer.

dvessel’s picture

dvessel commented
Status: Needs review » Reviewed & tested by the community

Well, thanks.

keith.smith’s picture

keith.smith commented

I'm confused. Is the patch in #5 right? It seems unrelated (or else *way* over my head in relation to this issue).

dvessel’s picture

dvessel commented
Status: Reviewed & tested by the community » Needs work

Ah!! sorry. I didn't even look.

starbow’s picture

starbow commented
StatusFileSize
new garland.patch765 bytes

On the plus side, I was wondering what happened to my content_types patch :)
Here is the right one for this issue.

starbow’s picture

starbow commented
Status: Needs work » Needs review
drawk’s picture

drawk commented
Component: theme system » Garland theme
dpearcefl’s picture

dpearcefl commented
Status: Needs review » Postponed (maintainer needs more info)

Is this issue fixed in the latest D6? is there any interest in pursuing this issue?

BTW: Your patch needs to be named properly for it to be accepted.
http://drupal.org/node/1054616

dpearcefl’s picture

dpearcefl commented
Status: Postponed (maintainer needs more info) » Needs work
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Closed (won't fix)

It's too late for markup improvements in D6.