Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
forms system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
8 Dec 2013 at 03:14 UTC
Updated:
29 Jul 2014 at 23:12 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
star-szrAdding a commit message to the issue summary so the folks who already worked on #1898480: [meta] form.inc - Convert theme_ functions to Twig and in the Twig sandbox get credit.
Comment #2
jeroentConverted theme_select to twig.
Patch attached.
Comment #4
jeroent2: drupal-convert_theme_select_to_twig-2152225-2.patch queued for re-testing.
Comment #5
star-szrComment #6
star-szrFixing parent issue.
Comment #7
joelpittetHere is a manual test of http://d8.dev/admin/config/people/accounts/display
There is no difference in the markup except whitespace.
Comment #8
joelpittetSome nitpicks to take care of.
This should be Prepares variables for select element templates.
Needs a period.
Needs a colon ':' at the end of this line.
Don't write the variable types. This should be something like "The option element children." or something along those lines. https://drupal.org/node/1823416#datatypes
Comment #9
longwaveComment #10
joelpittetThanks @longwave! This is ready for profiling and then RTBC.
Comment #11
joelpittetScenario:
admin/structure/types/manage/article/form-display
with a datetime field too.
http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=530ef14e56c65&...
http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=530ef14e56c65&...
Comment #12
webchickCommitted and pushed to 8.x. Thanks!