Convert theme_checkboxes() to Twig

split from twig conversion form meta.

2: 2152201-2-theme_checkboxes.patch queued for re-testing.

This patch applies fine on HEAD as at today's date, I am just getting the testbot to rerun so people can see it is OK

5: 2152201-theme_checkboxes.patch queued for re-testing.

Checkboxes for Custom Display Settings are displaying properly. HTML markup generated by the patch looks good. I've attached a screenshot.

Scenario:
Ran the test at path /form-test/checkboxes-zero/

=== 8.x..8.x compared (52e48e674e7b6..52e48ec52134e):

ct  : 39,243|39,243|0|0.0%
wt  : 339,071|338,388|-683|-0.2%
cpu : 335,190|334,563|-627|-0.2%
mu  : 26,483,056|26,483,056|0|0.0%
pmu : 26,556,384|26,556,384|0|0.0%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=52e48e674e7b6&...

=== 8.x..2152201-twig-theme-checkboxes compared (52e48e674e7b6..52e48ef364ce3):

ct  : 39,243|39,405|162|0.4%
wt  : 339,071|339,389|318|0.1%
cpu : 335,190|335,587|397|0.1%
mu  : 26,483,056|26,526,960|43,904|0.2%
pmu : 26,556,384|26,600,040|43,656|0.2%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=52e48e674e7b6&...

This has an RTBC from me, but it's my patch so... anybody else can second it:)

Thanks for joining the sprint this weekend @katy5289 and reviewing the patch.

Scenario for profiling
1. login as admin
2. select structure; contact form categories
3. select website feedback, click edit
4. go to manage fields
5. add new field
label: some check boxes
field type: list (integer)
6. click on save
7. enter that user must select at least 2 options
list of options:
10|check me 10
11|check me 11
12|check me 12
13|check me 13
14|check me 14
8. Save; go to manage display. select "checkboxes/radio" for display
9. now add another field
label: some radio buttons
field type: list (integer)
10. click on save
11. enter that user must select just 1 option
list of options:
1|check me 1
2|check me 2
3|check me 3
4|check me 4
5|check me 5
12. Save; go to manage display. select "checkboxes/radio" for display
13. go to system settings and enter as default page: /contact
14. now open site, contact form with checkboxes and radio buttons will be displayed.
15. now is good moment to backup database since it can be used again later for radio buttons

test results:
Run 52e49acfb0eb8 uploaded successfully for drupal-perf-drupalcon.
Run 52e49b28a90e1 uploaded successfully for drupal-perf-drupalcon.

=== 8.x..8.x compared (52e49acfb0eb8..52e49b28a90e1):

ct  : 41,877|41,877|0|0.0%
wt  : 169,090|169,376|286|0.2%
cpu : 157,381|157,806|425|0.3%
mu  : 14,621,216|14,621,216|0|0.0%
pmu : 14,735,680|14,735,680|0|0.0%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=52e49acfb0eb8&...

Run 52e49acfb0eb8 uploaded successfully for drupal-perf-drupalcon.
Run 52e49b394aea8 uploaded successfully for drupal-perf-drupalcon.

=== 8.x..2152201-7-checkboxes-twig compared (52e49acfb0eb8..52e49b394aea8):

ct  : 41,877|42,023|146|0.3%
wt  : 169,090|170,199|1,109|0.7%
cpu : 157,381|158,196|815|0.5%
mu  : 14,621,216|14,647,072|25,856|0.2%
pmu : 14,735,680|14,762,096|26,416|0.2%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=52e49acfb0eb8&...

DAM Joel, you are so fast ;-).
ok, we have 2 sets of result.

Please note that my test was run with twig debugger turned on.

I tested patch in #5 using the same procedure as descried in #11, and the markup for the checkboxes and radio button is the same before and after the patch.

Looks good to go.

+++ b/core/includes/form.inc
@@ -1225,29 +1225,32 @@ function form_pre_render_checkbox($element) {
+  // Remove the disabled attribute on the wrapper.
+  unset($variables['attributes']['disabled']);

Why is this set? And why is it necessary? Perhaps the comment could be improved?

@alexpott, the reason behind the unset is that we took away the attribute input clobbering that was done before... but that change probably shouldn't be in this patch and will likely be removed when consolidation with container.html.twig happens. So I added the clobbering back in, removed. Also removed the empty() check on $element['#children'] because it's always initiated in drupal_render().

Setting this back to needs manual testing.

17: 2152201-theme_checkboxes-17.patch queued for re-testing.

17: 2152201-theme_checkboxes-17.patch queued for re-testing.

Added steps to test and tagging as novice.

This looks fine to me, patch applies correctly, and the markup before and after is identical @ /form-test/checkboxes-zero/

Thank you @Manuel Garcia! The before got cut off a bit in the screenshot for the wrapper for the checkboxes but it is identical, this is taken from 8.x HEAD to compare against your screenshot in #23
<div id="edit-checkbox-zero-default" class="form-checkboxes fieldgroup form-composite">

The rest of the screenshot shows the inside checkboxes which aren't modified with this patch.

Thank you, for the RTBC again:)

Oops! thank you for completing it joelpittet =)

Committed and pushed to 8.x. Thanks!