Updated: Comment #0
Problem/Motivation
ConfigTestTranslationUITest tests that Content Translation module does not interfere with the storage of configuration entities. There are numerous problems with this:
* It's incredibly pointless: Conten Translation does not deal at all with configuration storage. It's mostly a UI module.
* Because it subclasses ContentTranslationUITest it inherits all sorts of things that make sense for translatable content entities. It tries to test this, however with the config_test entity. This is just wrong. @timplunkett recently ran into this, which led to the creation of this issue.
Proposed resolution
Remove ConfigTestTranslationUITest.
I originally wrote it in #1832932: translation_entity_entity_insert() assumes entity IDs are integers and it already has a todo to remove after #2004244: Move entity revision, content translation, validation and field methods to ContentEntityInterface.
Remaining tasks
User interface changes
API changes
Related Issues
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 2137063-1.patch | 3.29 KB | tstoeckler |
Comments
Comment #1
tstoecklerHere we go.
Comment #2
tim.plunkettI know they're unrelated but as much as I hate this test, I'd feel better if this waited for #1952394: Add configuration translation user interface module in core
Comment #3
plach+1 for #2
Comment #4
tstoecklerSo anyone up for an RTBC, now?
Comment #5
tim.plunkettYep
Comment #6
webchickTests--; :(
Committed and pushed to 8.x. Thanks!