Updated: Comment #0

Problem/Motivation

ConfigTestTranslationUITest tests that Content Translation module does not interfere with the storage of configuration entities. There are numerous problems with this:

* It's incredibly pointless: Conten Translation does not deal at all with configuration storage. It's mostly a UI module.
* Because it subclasses ContentTranslationUITest it inherits all sorts of things that make sense for translatable content entities. It tries to test this, however with the config_test entity. This is just wrong. @timplunkett recently ran into this, which led to the creation of this issue.

Proposed resolution

Remove ConfigTestTranslationUITest.

I originally wrote it in #1832932: translation_entity_entity_insert() assumes entity IDs are integers and it already has a todo to remove after #2004244: Move entity revision, content translation, validation and field methods to ContentEntityInterface.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 2137063-1.patch3.29 KBtstoeckler

Comments

tstoeckler’s picture

Status: Active » Needs review
StatusFileSize
new3.29 KB

Here we go.

tim.plunkett’s picture

I know they're unrelated but as much as I hate this test, I'd feel better if this waited for #1952394: Add configuration translation user interface module in core

plach’s picture

+1 for #2

tstoeckler’s picture

So anyone up for an RTBC, now?

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

Yep

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Tests--; :(

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.