Useless pass-by-reference

Note for other testers: This patch is not made from drupal root, but from modules/update. fgm, please diff from the root directory in the future, it makes things a lot more convenient. :)

Patch applies and causes no errors.

However, I'm curious about this:

In addition, this causes an error under E_ALL | E_STRICT

I wasn't able to trigger a notice by making the unpatched module check for updates... when should this happen?

I'm beginning to think the problem might be on my end.

error_reporting(E_STRICT);
var_dump(ini_get('error_reporting'));  // 2048

function test(&$i) {
  $i++;
  return $i;
}

function test2($i) {
  return $i;
}

var_dump(test(test2(0))); // *should* print a strict warning as return value passed by reference.
# var_dump(test(0)); // *does* print a fatal error, as literal passed by reference.

In fact, there will be no error output on my site from the above code. So I guess my test results should be ignored.

In any case, the patch has no side effects, it still applies cleanly, solves a redundancy and will bring the code toward E_STRICT compliance. So I'm going to go ahead and mark this ready.

Committed.