Updated: Comment #N

Problem/Motivation

In Drupal\number\Plugin\field\formatter\NumberDecimalFormatter::settingsForm, form elements are not well defined and uses 'weight' instead of '#weight' as parameter, which leds to the following warning message:
weight_warning.png

Proposed resolution

Change 'weight' and use the right parameter '#weight'.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#11 weight_warning-2114473-11.patch7.08 KBplopesc
#11 weight_warning-2114473-11-test-only.patch5.95 KBplopesc
#7 weight_warning-2114473-7.patch7.07 KBplopesc
#7 weight_warning-2114473-7-only-test.patch5.94 KBplopesc
#4 weight_warning-2114473-3.patch1.13 KBplopesc
#3 weight_warning-2114473-3.patch1.13 KBplopesc
#1 weight_warning-2114473-1.patch1.11 KBplopesc
weight_warning.png47.01 KBplopesc

Comments

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Active » Needs review
StatusFileSize
new weight_warning-2114473-1.patch1.11 KB

Patch

amateescu’s picture

amateescu commented
Status: Needs review » Reviewed & tested by the community

Looks good :)

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
StatusFileSize
new weight_warning-2114473-3.patch1.13 KB

Rerolled after #2050835: Move Widget, Formatter, and FieldType plugin types to the Core\Field system is in.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
StatusFileSize
new weight_warning-2114473-3.patch1.13 KB

Rerolled after #2050835: Move Widget, Formatter, and FieldType plugin types to the Core\Field system is in. Same patch that #3

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

#4: weight_warning-2114473-3.patch queued for re-testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

This means that this form is never ever tested

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
StatusFileSize
new weight_warning-2114473-7-only-test.patch5.94 KB
new weight_warning-2114473-7.patch7.07 KB

Adding tests

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: weight_warning-2114473-7-only-test.patch, failed testing.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs work » Needs review

Back to needs review given that last patch worked.
Regards

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Issue tags: -Needs tests
StatusFileSize
new weight_warning-2114473-11-test-only.patch5.95 KB
new weight_warning-2114473-11.patch7.08 KB

Re-rolling after #1988612: Apply formatters and widgets to rendered entity base fields, starting with node.title

The last submitted patch, 11: weight_warning-2114473-11-test-only.patch, failed testing.

swentel’s picture

swentel commented
Status: Needs review » Reviewed & tested by the community
swentel’s picture

swentel commented 
+++ b/core/modules/number/lib/Drupal/number/Tests/NumberFieldTest.php
@@ -189,21 +189,140 @@ function testNumberIntegerField() {
+    //Check number_integer formatter behavior.

Could a core committer add a space here ?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Love the tests! Committed 5e91589 and pushed to 8.x. Thanks!

Fixed in commit as requested...

diff --git a/core/modules/number/lib/Drupal/number/Tests/NumberFieldTest.php b/core/modules/number/lib/Drupal/number/Tests/NumberFieldTest.php
index 2ecd516..4dfe210 100644
--- a/core/modules/number/lib/Drupal/number/Tests/NumberFieldTest.php
+++ b/core/modules/number/lib/Drupal/number/Tests/NumberFieldTest.php
@@ -319,7 +319,7 @@ function testNumberFormatter() {
     $this->drupalPostAjaxForm(NULL, $edit, "${integer_field}_plugin_settings_update");
     $this->drupalPostForm(NULL, array(), t('Save'));

-    //Check number_integer formatter behavior.
+    // Check number_integer formatter behavior.
     $this->drupalGet('node/' . $node->id());

     $integer_formatted = number_format($random_integer, 0, '', $thousand_separator);

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.