Convert search_embedded_form_form to a Controller

Starting...

Initial patch version.

This looks fine to me, and besides which, the tests pass. Thanks!

It's going to conflict with
#1926344: Consolidate search-result.html.twig and search-results.html.twig

+++ b/core/modules/search/tests/modules/search_embedded_form/lib/Drupal/search_embedded_form/Form/SearchEmbeddedForm.php
@@ -7,16 +7,53 @@
+    $count = $this->container()->get('config.factory')
+      ->get('search_embedded_form.settings')->get('submitted');
...
+    $config = $this->container()->get('config.factory')->get('search_embedded_form.settings');

Should be using FormBase's config method

RE #5 - we just need to convert

 $this->container()->get('config.factory')->get()

to

 $this->config()

I believe.

RoSk0: If you'd like to make a new patch, with an interdiff, that would be great!
https://drupal.org/documentation/git/interdiff
If you do not have time, unassign the issue and we'll find someone else. Thanks!

Update.

Thanks!

The interdiff looks right to me.

I also went back and reviewed the whole patch... and I think we should be using the State system instead of the Config system to save the count of how many times the form has been submitted -- it seems like state information and not configuration information. However, I think that is a separate issue. This issue was about converting the existing form to be a form class, and the patch is fine for that. Follow-up: #2122321: search_embedded_form test module is improperly using config instead of state

But there is one small error in this patch:

+ * Form controller for search_embedded_form form.
  */
-class SearchEmbeddedForm {
+class SearchEmbeddedForm extends FormBase {
...
+  public function getFormID() {
+    return 'search_embedded_form_form';
+  }

The docs here say it is for search_embedded_form but the form ID is actually search_embedded_form_form. One or the other should be changed -- they need to match. Thanks!

Fixed.

Excellent! I think this is ready to go in now.

We have two issues that are postponed on this getting committed -- adding them to related issues. Also I'll click retest just in case since it's been a while since the last test.

9: drupal8.search-module.2105609-9.patch queued for re-testing.

9: drupal8.search-module.2105609-9.patch queued for re-testing.

Committed and pushed to 8.x. Thanks!