Subtask of #1830588: [META] remove drupal_set_title() and drupal_get_title()

Problem/Motivation

Using procedural drupal_set_title() inside controller class is not encouraged.

Proposed resolution

Replace drupal_set_title() with #title in page return array.

Remaining tasks

Issue patch

User interface changes

Refer parent issue at #1830588: [META] remove drupal_set_title() and drupal_get_title()

API changes

Refer parent issue at #1830588: [META] remove drupal_set_title() and drupal_get_title()

CommentFileSizeAuthor
#2 drupal-comment_remove_drupal_set_title_2102437.patch926 bytesinternetdevels

Comments

rteijeiro’s picture

rteijeiro commented
Assigned: Unassigned » rteijeiro

I will take this one ;)

internetdevels’s picture

internetdevels commented
Component: block.module » comment.module
Status: Active » Needs review
StatusFileSize
new drupal-comment_remove_drupal_set_title_2102437.patch926 bytes

Sorry, but I think 3 days too much for implement this patch.

rteijeiro’s picture

rteijeiro commented
Assigned: rteijeiro » Unassigned

Unassigned.

andypost’s picture

andypost
he/him
Primary language Russian
commented

Looks good, but #2102125-75: Big Local Task Conversion implements it differently

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Closed (duplicate)

Would be fixed in #2102125-75: Big Local Task Conversion