ConfigEntityInterface::setOriginalID() should return $this, just like any other setter.

CommentFileSizeAuthor
#8 interdiff.txt1.15 KBxano
#8 drupal_2088241_8.patch7.68 KBxano
#7 drupal_2088241_6.patch7.71 KBxano
#7 interdiff.txt729 bytesxano
#3 drupal_2088241_3.patch6.81 KBxano
#3 interdiff.txt6.27 KBxano
#1 drupal_2088241_1.patch999 bytesxano

Comments

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Assigned: xano » Unassigned
Status: Active » Needs review
StatusFileSize
new drupal_2088241_1.patch999 bytes

Also, should the method name not be setOriginalId()?

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +Needs tests

I also agree that it should be name setOriginalId

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
StatusFileSize
new interdiff.txt6.27 KB
new drupal_2088241_3.patch6.81 KB
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Issue tags: -Needs tests

.

Status: Needs review » Needs work

The last submitted patch, drupal_2088241_3.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented 
  1. +++ b/core/lib/Drupal/Core/Config/Entity/ConfigEntityInterface.php
@@ -28,9 +28,9 @@ public function getOriginalID();
-   * @return void
+   * @return \Drupal\Core\Config\Entity\ConfigEntityInterface

    We are using '@return self' in quite some places which gives even more information. 

  2. +++ b/core/modules/config/lib/Drupal/config/Tests/ConfigEntityUnitTest.php
@@ -62,12 +78,22 @@ public function testStorageControllerMethods() {
+    $this->assertTrue($entity->setOriginalId($id) instanceof EntityInterface);

    We could even check that it is the same object using spl_object_hash

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt729 bytes
new drupal_2088241_6.patch7.71 KB
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
StatusFileSize
new drupal_2088241_8.patch7.68 KB
new interdiff.txt1.15 KB
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Thank you!

xjm’s picture

xjm
she/her
Primary language English
commented
Category: feature » task
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: ConfigEntityInterface::setOriginalID() should return $this » Change notice: ConfigEntityInterface::setOriginalID() should return $this
Priority: Normal » Major
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Committed and pushed to 8.x. Thanks!

Will need a change notice.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Title: Change notice: ConfigEntityInterface::setOriginalID() should return $this » ConfigEntityInterface::setOriginalID() should return $this
Priority: Major » Normal
Status: Active » Fixed
Issue tags: -Needs change record

Change notice is at https://drupal.org/node/2107951.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

For some reason the capitalization issue was never fixed or rolled back. See #2113319: Rename getOriginalID() to getOriginalId() and setOriginalID() to setOriginalId().

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.