Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
aggregator.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
9 Sep 2013 at 21:19 UTC
Updated:
29 Jul 2014 at 22:53 UTC
Jump to comment: Most recent file
Comments
Comment #1
ParisLiakos commentedalso as part of #2068325: [META] Convert entity SQL queries to the Entity Query API (we already have a major open for this)
Comment #2
kim.pepperThis simply moves the db queries into FeedStorageController. Not sure how to do the entity query stuff in #1.
Comment #4
ParisLiakos commentedso the more i look at this query the more i think we can replace this with just an aggregator_feed_load($derivative_id) and then just check $feed->block->value and bail out
This i would call it loadBlockEnabled()
Those methods from the feed storage should return a full loaded entity, so we can also standarize on calls like id() or label()..fetchObject only gives an stdClass.
You can check
\Drupal\aggregator\Form\OpmlFeedAddto see how ti worksFinally though:
I noticed that #1888702: Use configuration selection instead of derivatives for some blocks kills both those queries and i think it will eventually get in, so we should probably postpone this issue
Comment #5
ParisLiakos commentedyeap, those classes where removed