Move field.module constants related to storage to EntityStorageControllerInterface

+++ b/core/modules/field/lib/Drupal/field/Plugin/views/field/Field.php
@@ -202,6 +202,7 @@ public function query($use_groupby = FALSE) {
+      // @todo: What is this?
       $rkey = $this->definition['is revision'] ? 'FIELD_LOAD_REVISION' : 'FIELD_LOAD_CURRENT';

We can just use the constants properly here

Looks good now.

#8: load-constants-2079011-8.patch queued for re-testing.

Looks still ok :)

Thanks folks ! I'm fine with this getting in to clean obvious scope issues, but I opened #2081513: [pp-1] Deprecate FIELD_LOAD_* constants for more thoughts on those constants.

+++ b/core/modules/field/lib/Drupal/field/Plugin/views/field/Field.php
@@ -202,7 +203,7 @@ public function query($use_groupby = FALSE) {
       $fields = array();
-      $rkey = $this->definition['is revision'] ? 'FIELD_LOAD_REVISION' : 'FIELD_LOAD_CURRENT';
+      $rkey = $this->definition['is revision'] ? EntityStorageControllerInterface::FIELD_LOAD_REVISION : EntityStorageControllerInterface::FIELD_LOAD_CURRENT;
       // Go through the list and determine the actual column name from field api.

Side note: this code looks wrong / broken anyway, see #2081533: Views "group by" on "Field API" fields broken

Patch no longer applies :) rerolled - I'm all for getting this is and then working out if we can do without them

The interdiff was empty :) so attaching diff that shows a line that's unchanged by this patch has been changed.

Committed/pushed to 8.x, thanks!

Needs a change notice.

Change notice created: https://drupal.org/node/2082357

Untagging. Please remove the tag when the change notification task is completed.