modules/forum/forum.module:767:        $variables['forums'][$id]->new_text = t('!count new', array('!count' => $variables['forums'][$id]->new_topics));
modules/forum/forum.module:829:        $variables['topics'][$id]->new_text = t('!count new', array('!count' => $variables['forums'][$id]->new_topics));
CommentFileSizeAuthor
#8 forum-plural2.patch1.61 KBdvessel
#2 forum-plural.patch1.61 KBgábor hojtsy

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

This should use format_plural() as in tracker.pages.inc for example: format_plural($new, '1 new', '@count new')

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Active » Needs review
StatusFileSize
new forum-plural.patch1.61 KB

I though I'd look into this and fix quickly, but then realized that the second case might have been a bogus direct copy of the first, as in the second case, we might need to deal with the $topic->new_replies and not the $variables['forums'][$id]->new_topics. I did not have time to test this now tough, so here is the patch for testing.

dvessel’s picture

dvessel commented
Status: Needs review » Closed (works as designed)

Plural? Why? "new" is new... 1 new/2 new/etc..

Or my grasp on the language is poor. ;)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Closed (works as designed) » Needs review

Tracker module already uses a plural friendly @count new. I am not sure what languages might be affected, Hungarian is not, but meba reported this, and he does the Czech translation. Also, in #2 I noted that there might be a copy-paste bug there, if we look closer, so the wrong count might be displayed. Therefore I would not mark this by design even if there will be no plural use there.

meba’s picture

meba commented

Czech:

1 new = 1 nový
2 new = 2 nové
5 new = 5 nových

meba’s picture

meba commented
Status: Needs review » Active

Seems OK for me

meba’s picture

meba commented
Status: Active » Needs review

Setting back status, sorry

dvessel’s picture

dvessel commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new forum-plural2.patch1.61 KB

heh, excuse me.

Gábor, your right. The second one would be a bug. This patch is the same, just clears the fuzz.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.