Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Needed for #1983554: Remove BC-mode from EntityNG .
Comment | File | Size | Author |
---|---|---|---|
#6 | entity-bc-removal-from-test-entities-6.patch | 3.26 KB | effulgentsia |
#6 | interdiff.txt | 710 bytes | effulgentsia |
#4 | entity-bc-removal-from-test-entities-4.patch | 2.4 KB | effulgentsia |
#4 | interdiff.txt | 1.41 KB | effulgentsia |
entity-bc-removal-from-test-entities.patch | 1.97 KB | effulgentsia | |
Comments
Comment #1
effulgentsia CreditAttribution: effulgentsia commentedTagging.
Comment #3
BerdirWondering why we have EntityCacheTest and EntityTestCache...
Ah, EntityCacheTest is used in that weird EntityApiInfoTest that tests entity info altering and module enable crazyness. Should be possible to remove that and switch another of our test entities...
And FieldUITestNoBundle was added in #1986888: Field UI integration for entity types is brittle.
Note that just extending from EntityNG and using the NG storage is somewhat weird, because that means it is impossible to actually use those entity types (was already not really possible before).
Comment #4
effulgentsia CreditAttribution: effulgentsia commentedLet's see if this at least lets the tests run.
Comment #6
effulgentsia CreditAttribution: effulgentsia commentedRe #3, I agree these test classes seem a bit superfluous, but not sure how to best remove them. If that's easy to do, please post a patch for it. Otherwise, just trying to remove the blockers to #1983554: Remove BC-mode from EntityNG .
Comment #7
BerdirNot sure if it's technically a blocker for removing the BC decorator, the BC decorator is only used for already converted entity types that still need to be accessed the old way.
But it certainly makes sense, especially given the direction I'm moving to in #2004244: Move entity revision, content translation, validation and field methods to ContentEntityInterface (Which basically makes EntityNG ContentEntityBase and will limit a number of features to ContentEntityInterface, like being able to be fieldable, translatable, ...). Will try to post an updated issue summary there ASAP.
Will RTBC this once it's green, we can still think about re-using other entity types in non-critical issues.
Comment #8
effulgentsia CreditAttribution: effulgentsia commented#6 is green :)
Comment #9
BerdirYeah, I know. The problem is that I would have to change everything you're changing here again in #2004244: Move entity revision, content translation, validation and field methods to ContentEntityInterface (at least the entity classes), so this is somewhat pointless. Might be easier to just merge into that from the start. Or find a way to drop those types.
Comment #10
effulgentsia CreditAttribution: effulgentsia commentedAh, ok. This isn't urgent, can postpone on that issue.
Comment #11
BerdirSo, the BC mode is gone and the issue that I referenced is in, so this is no longer blocked and also no longer critical.
It also means we can aim for a nice solution instead :)
Comment #12
BerdirThose two no longer exist and/or have been converted elsewhere/otherwise.