Let's start to convert all calls to user_access() with the new AccountInterface::hasPermission() method.

Part of #2048171: [meta] Replace user_access() calls with $account->hasPermission() wherever possible.

Change records for this issue:

CommentFileSizeAuthor
#4 drupal-picture_replace_user_access-2062015-4.patch1.02 KBphiit
#1 drupal-picture_replace_user_access-2062015.patch1.71 KBinternetdevels

Comments

internetdevels’s picture

internetdevels commented
Status: Active » Needs review
StatusFileSize
new drupal-picture_replace_user_access-2062015.patch1.71 KB

Here is the patch.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community 
+++ b/core/modules/picture/lib/Drupal/picture/PictureMappingListController.php
@@ -25,7 +25,6 @@ public function hookMenu() {
-    $items[$path]['access callback'] = 'user_access';

Nice clean-up, defaults already provides this.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Patch no longer applies

phiit’s picture

phiit commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new drupal-picture_replace_user_access-2062015-4.patch1.02 KB

Rerolled

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Great!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.