Let's start to convert all calls to user_access() with the new AccountInterface::hasPermission() method.

Part of #2048171: [meta] Replace user_access() calls with $account->hasPermission() wherever possible.

Change records for this issue:

CommentFileSizeAuthor
#7 replace-user_access-2061979-7.patch765 bytesmichaelhiiva
#7 interdiff-2061979-1-7.txt913 bytesmichaelhiiva
#5 replace-user_access-2061979-5.patch813 bytesmichaelhiiva
#5 innerdiff-2061979-1-5.txt831 bytesmichaelhiiva
#4 innerdiff-2061979-1-4.txt831 bytesmichaelhiiva
#4 drupal-contextual_replace_user_access-2061979-4.patch859 bytesmichaelhiiva
#1 drupal-contextual_replace_user_access-2061979.patch859 bytesinternetdevels

Comments

internetdevels’s picture

internetdevels commented
Status: Active » Needs review
StatusFileSize
new drupal-contextual_replace_user_access-2061979.patch859 bytes

Here is the patch.

Status: Needs review » Needs work

The last submitted patch, drupal-contextual_replace_user_access-2061979.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
commented 
+++ b/core/modules/contextual/contextual.module
@@ -23,7 +23,8 @@ function contextual_menu() {
+  $account = Drupal::request()->attributes->get('_account');

@@ -61,7 +62,8 @@ function contextual_toolbar() {
+  $account = Drupal::request()->attributes->get('_account');

Use Drupal::currentUser() service https://drupal.org/node/2032447

michaelhiiva’s picture

michaelhiiva commented
Status: Needs work » Needs review
StatusFileSize
new drupal-contextual_replace_user_access-2061979-4.patch859 bytes
new innerdiff-2061979-1-4.txt831 bytes
michaelhiiva’s picture

michaelhiiva commented
StatusFileSize
new innerdiff-2061979-1-5.txt831 bytes
new replace-user_access-2061979-5.patch813 bytes

Provided wrong patch in #4.

andypost’s picture

andypost
he/him
Primary language Russian
commented 
  1. +++ b/core/modules/contextual/contextual.module
@@ -23,7 +23,8 @@ function contextual_menu() {
+  $account = \Drupal::currentUser();

@@ -61,7 +62,9 @@ function contextual_toolbar() {
+  $account = \Drupal::currentUser();

    the '\' is not needed in procedural code 

  2. +++ b/core/modules/contextual/contextual.module
@@ -23,7 +23,8 @@ function contextual_menu() {
+  if (!$account->hasPermission('access contextual links')) {

@@ -61,7 +62,9 @@ function contextual_toolbar() {
+  if (!$account->hasPermission('access contextual links')) {

    Drupal::currentUser()->hasPermission() is enough

michaelhiiva’s picture

michaelhiiva commented
StatusFileSize
new interdiff-2061979-1-7.txt913 bytes
new replace-user_access-2061979-7.patch765 bytes

@andypost Thanks for the information.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Great!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.