#1895160: Convert admin/content to a View, keep a non-views fallback with no bulk operations converted admin/content to a view, but it failed to include the "new" and "update" indicators. I grepped that page, and nobody noticed this. However, it is a critical feature for content administrators to keep track of what they've already read.

Views has a "Content: has new content" field. It should be used.

CommentFileSizeAuthor
#7 vdc-2043403-7.patch4.64 KBbdone
#7 interdiff-7-3.txt383 bytesbdone
#3 vdc-2043403-3.patch4.77 KBbdone
#3 Screen Shot 2013-07-19 at 8.47.57 AM.png97.38 KBbdone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Title: admin/content view does not have "new"/"update" indicators » admin/content View does not have "new"/"update" indicators
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue tags: +Novice

Adding novice task.

bdone’s picture

bdone CreditAttribution: bdone commented
Status: Active » Needs review
FileSize
Screen Shot 2013-07-19 at 8.47.57 AM.png97.38 KB
vdc-2043403-3.patch4.77 KB

here's a patch adding the timestamp field (label: "Has new content") to all displays in views.view.content. it displays timestamp in the Title column, similar to the pre-views version in #1895160: Convert admin/content to a View, keep a non-views fallback with no bulk operations.

node content view

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Needs review » Needs work

Lovely! Thanks!

The patch contains a UUID though and seems to include unrelated changes?

bdone’s picture

bdone CreditAttribution: bdone commented

@Wim Leers, yea i wasn't sure about that. I updated the view, exported config, and i guess that process added uuid.

I found a lot of instances of uuids in core/modules and wondered about that. what's the best thing here, simply remove that line?

i'm also wondering the right workflow to update config like this and avoid this kinda thing.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented

Hm… AFAIK all existing UUIDs in core config .yml files shouldn't be there. But yes, it's super easy to fix: just remove that hunk of the patch :)
I don't think it's posible to avoid this; the reason it can't be here is because this is Drupal core, not a specific site. For a specific site, you *want* that UUID to be there, for downloadable (Drupal contrib) modules (and Drupal core), you *don't* want them.

+++ b/core/modules/node/config/views.view.content.ymlundefined
@@ -49,44 +51,82 @@ display:
+              align: ''
+              separator: ''

Changes like these are what I meant by "unrelated changes". I think a Views person should review this aspect, I can't comment on that with authority!

bdone’s picture

bdone CreditAttribution: bdone commented
Status: Needs work » Needs review
FileSize
interdiff-7-3.txt383 bytes
vdc-2043403-7.patch4.64 KB

thanks for the explanation @Wim Leers. i've since removed uuid. will await some feedback from a vdc maintainer.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Reviewed & tested by the community

Nope, the patch in #3 is correct. We want all of that stuff!

The patch to commit is #3 not #7.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Yep we want all the stuff :)

Committed 03649a3 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Component: node.module » node system
Issue summary: View changes