Task to convert Drupal\system\Tests\Routing\RouteTest to phpunit.

See #1938068: Convert UnitTestBase to PHPUnit.

CommentFileSizeAuthor
#6 interdiff.txt511 bytesjhedstrom
#6 system-routecompilertest-phpunit-2042745-06.patch2.86 KBjhedstrom
#4 interdiff.txt630 bytesjhedstrom
#4 system-routecompilertest-phpunit-2042745-04.patch2.85 KBjhedstrom
#1 system-routetest-phpunit-2042745-01.patch2.77 KBjhedstrom

Comments

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Active » Needs review
StatusFileSize
new system-routetest-phpunit-2042745-01.patch2.77 KB

This one also quite straightforward.

dawehner’s picture

dawehner
Primary language German
commented 
+++ b/core/tests/Drupal/Tests/Core/Routing/RouteTest.phpundefined
@@ -2,19 +2,20 @@
+class RouteTest extends UnitTestCase {

This test seems to test the drupal route compiler, not the Route object coming from symfony. Should we reflect that in the name of the test?

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work

Back to needs work, sorry.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs work » Needs review
StatusFileSize
new system-routecompilertest-phpunit-2042745-04.patch2.85 KB
new interdiff.txt630 bytes

Renamed to reflect that this is actually testing \Drupal\Core\Routing\RouteCompiler.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work 
+++ b/core/tests/Drupal/Tests/Core/Routing/RouteCompilerTest.phpundefined
@@ -2,19 +2,22 @@
+ * Contains Drupal\Tests\Core\Routing\RouteCompilerTest.
...
+class RouteTest extends UnitTestCase {

You missed to rename the class itself :(

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs work » Needs review
StatusFileSize
new system-routecompilertest-phpunit-2042745-06.patch2.86 KB
new interdiff.txt511 bytes

Doh!

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

This looks great now!

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Updated issue summary.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Issue summary: View changes
Parent issue: » #1938068: Convert UnitTestBase to PHPUnit