Comments

jlindsey15’s picture

Assigned: Unassigned » jlindsey15

I'll get a patch out in a bit.

jlindsey15’s picture

Status: Active » Needs review
StatusFileSize
new2.6 KB

Status: Needs review » Needs work

The last submitted patch, pluginUIManager-2039535-1.patch, failed testing.

jlindsey15’s picture

Status: Needs work » Needs review
StatusFileSize
new2.6 KB

Status: Needs review » Needs work

The last submitted patch, pluginUIManager-2039535-4.patch, failed testing.

jlindsey15’s picture

Status: Needs work » Needs review

Hmm... the patch applies fine locally... I guess I'm missing something.

jlindsey15’s picture

StatusFileSize
new3.23 KB

Aha this might work.

berdir’s picture

Status: Needs review » Needs work
+++ b/core/modules/system/lib/Drupal/system/Plugin/Type/PluginUIManager.phpundefined
@@ -7,33 +7,35 @@
-    $this->discovery = new AlterDecorator($this->discovery, 'plugin_ui');
-    $this->discovery = new CacheDecorator($this->discovery, 'plugin_ui');
...
+    $this->alterInfo($module_handler, 'pluginUI_info');
+    $this->setCacheBackend($cache_backend, $language_manager, 'pluginUI');

Why rename the hook? Apart from camel case being wrong here anyway, it seems like an unrelated API change.

jlindsey15’s picture

Status: Needs work » Needs review
StatusFileSize
new3.22 KB

Bleh the line right above those got me into camelCase mode... :(

Status: Needs review » Needs work

The last submitted patch, pluginUIManager-2039535-9.patch, failed testing.

jlindsey15’s picture

Status: Needs work » Needs review
StatusFileSize
new3.23 KB

Here we go - I guess I wasn't synced when I made the patch even though I thought I was...

Status: Needs review » Needs work

The last submitted patch, pluginUIManager-2039535-11.patch, failed testing.

berdir’s picture

Status: Needs work » Closed (won't fix)

PluginUI is on its way out, so I believe we can close this: #2056513: Remove PluginUI subsystem, provide block plugins UI as one-off.

aks22’s picture

Issue summary: View changes