Part of #2034951: [META] Support and test all field formatters RDFa output

CommentFileSizeAuthor
#7 2034995-07-test-taxonomy-term-formatter.patch3.1 KBjesse.d
#4 2034995-04-taxonomy-term-formatter-test_includes2034977.patch5.92 KBlinclark
#4 2034995-04-taxonomy-term-formatter-test-do-not-test.patch3.1 KBlinclark
#4 interdiff.txt734 byteslinclark
#2 2034995-02-taxonomy-term-formatter-test_includes2034977.patch5.9 KBlinclark
#2 2034995-02-taxonomy-term-formatter-test-do-not-test.patch3.1 KBlinclark
#1 2034995-01-taxonomy-term-formatter-test_includes2034977.patch6.77 KBlinclark
#1 2034995-01-taxonomy-term-formatter-test-do-not-test.patch3.97 KBlinclark

Comments

linclark’s picture

linclark commented
StatusFileSize
new 2034995-01-taxonomy-term-formatter-test-do-not-test.patch3.97 KB
new 2034995-01-taxonomy-term-formatter-test_includes2034977.patch6.77 KB

Just posting these here, they will fail because our formatter doesn't currently work independent of some hackery in rdf.module and dependency on RDFa parsing trickery that we don't plan to use in D8.

linclark’s picture

linclark commented
Status: Active » Needs review
StatusFileSize
new 2034995-02-taxonomy-term-formatter-test-do-not-test.patch3.1 KB
new 2034995-02-taxonomy-term-formatter-test_includes2034977.patch5.9 KB

This makes the test pass on the link formatter as it is.

Status: Needs review » Needs work

The last submitted patch, 2034995-02-taxonomy-term-formatter-test_includes2034977.patch, failed testing.

linclark’s picture

linclark commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt734 bytes
new 2034995-04-taxonomy-term-formatter-test-do-not-test.patch3.1 KB
new 2034995-04-taxonomy-term-formatter-test_includes2034977.patch5.92 KB

This rerolls the test based on a change in #2034977: Create a base class for formatter RDFa tests. I couldn't reproduce the fail on my local, so I'm going to try it again to see whether StandardProfile still fails.

jesse.d’s picture

jesse.d commented

#4: 2034995-04-taxonomy-term-formatter-test_includes2034977.patch queued for re-testing.

scor’s picture

scor commented
Status: Needs review » Needs work

This needs reroll to incorporate #2034977: Create a base class for formatter RDFa tests.

jesse.d’s picture

jesse.d commented
Status: Needs work » Needs review
StatusFileSize
new 2034995-07-test-taxonomy-term-formatter.patch3.1 KB

#4 without the base class file.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Issue summary: View changes
Status: Needs review » Closed (fixed)

An improved version of this code appears in #1778122-113: Enable modules to inject attributes into field formatters, so that RDF attributes get output.