Part of meta-issue #2016679: Expand Entity Type interfaces to provide methods, protect the properties.

See the detailed explanations there and look at the issues that already have patches or were commited.

Add get*, set* and additional methods as it makes sense to replace the public properties (e.g. isSomething() and something())

CommentFileSizeAuthor
#2 menu-link-2030649-2.patch3.64 KBtim.plunkett
#1 menu-link-interface-methods-2030649-2.patch1.51 KBkevin.reiss

Comments

kevin.reiss’s picture

kevin.reiss commented
Assigned: Unassigned » kevin.reiss
Status: Active » Needs work
StatusFileSize
new menu-link-interface-methods-2030649-2.patch1.51 KB

Starting to work on this. Per the instructions on the meta-issue 2016679 I will stick to properties unique to the interface. The attached patch is a just a starter since menulink has quite a few properties.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
StatusFileSize
new menu-link-2030649-2.patch3.64 KB

There are even more hidden properties.

@kevin.reiss are you still working on this?

amateescu’s picture

amateescu commented
Component: menu.module » menu_link.module
Status: Needs review » Needs work

Those are not properties internal to the menu_link entity, they come from {menu_router} because I had to use a BC layer in order to keep things working until {menu_router} is removed.

yesct’s picture

yesct commented
Assigned: kevin.reiss » Unassigned

@kevin.reiss I'm going to make this available for someone to work on by unassigning it. If you want it back, just repost and let us know you'll work on it. :) No worries.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Closed (duplicate)

Closing as duplicate of #1842858: [PP-1] Convert menu links to the new Entity Field API