Part of meta-issue #2016679: Expand Entity Type interfaces to provide methods, protect the properties.

See the detailed explanations there and look at the issues that already have patches or were commited.

Add get*, set* and additional methods as it makes sense to replace the public properties (e.g. isSomething() and something())

CommentFileSizeAuthor
#5 image-entity-expand-with-methods-2030643-5.patch2.41 KBtarekdj
#2 image-entity-expand-with-methods-2030643-2.patch2.42 KBinternetdevels

Comments

G2’s picture

G2 commented
Assigned: Unassigned » G2
internetdevels’s picture

internetdevels commented
Assigned: G2 » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new image-entity-expand-with-methods-2030643-2.patch2.42 KB

Here is the patch.

deneo’s picture

deneo commented
Status: Needs review » Reviewed & tested by the community

The patch is good. It solve the issue and fully comply with coding standards. Thank you!

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work 
  1. +++ b/core/modules/image/lib/Drupal/image/ImageStyleInterface.php
@@ -16,6 +16,34 @@
+   * Returns the replacement id.

    ID. Also is it an ID or a name? 

  2. +++ b/core/modules/image/lib/Drupal/image/ImageStyleInterface.php
@@ -16,6 +16,34 @@
+   *   The name of the image style is placed in.

    "The name of the image style is placed in" isn't a complete sentence. 

  3. +++ b/core/modules/image/lib/Drupal/image/ImageStyleInterface.php
@@ -16,6 +16,34 @@
+   * Set the name of the image style.

    Set/Sets.

tarekdj’s picture

tarekdj commented
Assigned: Unassigned » tarekdj
StatusFileSize
new image-entity-expand-with-methods-2030643-5.patch2.41 KB
tarekdj’s picture

tarekdj commented
Status: Needs work » Needs review
plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs review » Reviewed & tested by the community

Thanks tarekdj, it looks good to me :)

Next time, please attach an interdiff file. It makes review easier.

RTBC if still green.

tarekdj’s picture

tarekdj commented

Ok plopesc! got it ;). thanks!

xjm’s picture

xjm
she/her
Primary language English
commented

5: image-entity-expand-with-methods-2030643-5.patch queued for re-testing.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.