In Admin | Site builder | Modules, the link at the top of the page "Uninstall" is ambiguous suggesting it uninstalls one or more modules.

It would be better if "Uninstall" was labelled "List Uninstallable".

And perhaps then, "List" should be "List All",

CommentFileSizeAuthor
#2 system.module.diff147 bytesfossdeveloper

Comments

fossdeveloper’s picture

fossdeveloper commented
Category: bug » feature
Priority: Minor » Normal

yes that will be a better way to do it.

i am new developer so which file is this located ?

fossdeveloper’s picture

fossdeveloper commented
Component: admin.module » system.module
StatusFileSize
new system.module.diff147 bytes

Ok I have made the changes to /modules/system/system.module

This is my first open source patch that I making !!!!

:D

Please comment and excuse my mistakes :)

Thanks a lot guys for a great CMS

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Version: 6.0-rc1 » 7.x-dev
Component: system.module » user interface text
Status: Active » Needs review

i don't like it..

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Needs work

Tabs are usually verbs and usually terse. This is not a good patch IMO

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

First, make sure to use "diff -up" when creating patches. Second, I am in agreement with #3 and #4. This would be inconsistent with the current text all around core. But maybe there would be a way to get a hover description for the "uninstall" tab using $menu['item']['description']?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Closed (won't fix)

Three votes no, so going to mark as wont-fix.