Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Similar to #2019651: Add a QueryFactoryInterface for QueryFactory classes.
We have a lot of places typehinting with ConfigFactory directly, which is against our standards, and it has plenty of public methods we could document.
Comment | File | Size | Author |
---|---|---|---|
#34 | config-2021111-34.patch | 12.4 KB | jibran |
#34 | interdiff.txt | 701 bytes | jibran |
#32 | config-2021111-32.patch | 12.41 KB | jibran |
#29 | config-2021111-29.patch | 11.1 KB | jibran |
#29 | interdiff.txt | 411 bytes | jibran |
Comments
Comment #1
tim.plunkettComment #2
tim.plunkett#1: config-factory-2021111-1.patch queued for re-testing.
Comment #4
tim.plunkettRerolled. This would be nice to get in.
Comment #5
andypost4: config-2021111-4.patch queued for re-testing.
Comment #7
jibranReroll and some more fixes.
Comment #9
jibranHere is the fix. Fails shows the benefit of having interface :D
Comment #10
andypostThis fixes
Configfactory
into interface, no api changes hereComment #11
xjm9: config-2021111-9.patch queued for re-testing.
Comment #13
jibranSimple reroll.
Comment #14
jibranNeeds roll after #2163371: Replace \Drupal:config()->get with ConfigFactory::loadMultiple in Drupal\Core\Config\Entity\Query.
Comment #15
mtiftHere's a re-roll
Comment #16
catchGiving Alex a chance to look at this before it goes in, makes sense to me although it could conflict with quite a lot.
Comment #17
jibran15: config-2021111-15.patch queued for re-testing.
Comment #19
jibranOnce more patch needs reroll. Please add 'Avoid commit conflicts' once RTBC and assign back it to @alexpott. Thank you @catch for having the look and @mtift for the reroll.
Comment #20
alexpottPostponing on #2098119: Replace config context system with baked-in locale support and single-event based overrides
Personally I think we should do this in two steps - get the interface in and the config factory using it - and then do the type hinting changes.
Comment #21
jibranHere is step 1. Please review I have created the patch from scratch.
Comment #22
alexpottVery minor - missing a space after the comma. Otherwise looks good.
Comment #23
jibranThis is an event function should I remove it form interface?
Comment #24
alexpott#23 yep that is a good point.
Comment #25
jibranHere we go.
Comment #26
alexpottNeeds reverting too :)
Comment #27
jibranMy bad. Fixed
Comment #28
alexpottShould be
Contains \Drupal\Core\Config\ConfigFactory.
Comment #29
jibransrlsy NW :P. Fixed.
Comment #30
alexpottLooks great - thanks!
Comment #31
alexpottNeeds reroll - conflicts with #2108599: Convert language_default to CMI
Comment #32
jibranReroll
Comment #33
alexpottpostponing on #2172561: Config overrides may spill over to undesired places - this patch is just going to go through re-roll hell :(
Comment #34
jibranHere we go again. With minor doc fixes.
Comment #35
alexpottI can't think of any other rtbc patches that are doing anything to the ConfigFactory so this one should be good to go!
Thanks for sticking with @jibran
Comment #37
alexpott34: config-2021111-34.patch queued for re-testing.
Comment #38
jibranBack to RTBC then.
Comment #39
alexpottCommitted f1fdcfa and pushed to 8.x. Thanks!
Comment #40
jibran#2184231: Use ConfigFactoryInterface to type hint ConfigFactory added as a child issue. Thanks everyone. Thank you @alexpott for the commit.