Create Drupal::languageManager for improved DX [#2020249]

At the moment we have very few usages of Drupal::service('language_manager') throughout core, but as soon as #1862202: Objectify the language system lands this number will explode, AAMOF all occurrences of language_list() will be deprectaed in favor of direct calls to the language manager.

This seems a good time to add the helper Drupal::languageManager() method.

Comment	File	Size	Author
#1	language-service_wrapper-2020249-1.patch	1.54 KB	plach
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

plach

he/him

Italian

Venezia

CreditAttribution: plach commented 15 June 2013 at 01:54

Status:	Active	» Needs review
Issue tags:		+Quick fix

File	Size
language-service_wrapper-2020249-1.patch	1.54 KB

And here it is.

Comment #2

ParisLiakos CreditAttribution: ParisLiakos commented 15 June 2013 at 02:03

Status:

Needs review

» Reviewed & tested by the community

makes sense

Comment #3

Berdir

German

Switzerland

CreditAttribution: Berdir commented 15 June 2013 at 05:58

Agreed. And this is fine to get in.

That said, Drupal::languageManager()->getLanguage(Language::TYPE_INTERFACE) is still quite ugly, among other things because you need a use for Language and we went to great length to avoid that you have to use Drupal in procedural code. Of which we have less and less but still a fair bit and contrib will have a lot.

So, given that we have constants for those anyway, what about introducing helper methods (in a follow-up issue, of course) for those hardcoded types: Drupal::languageManager()->getInterfaceLanguage()?