Depends on #1969728: Implement Field API "field types" as TypedData Plugins
Instructions are on #2014671: [META] Convert all field types to plugins

CommentFileSizeAuthor
#10 2017139-10.patch9.26 KBamateescu
#10 interdiff.txt2.03 KBamateescu
#8 2017139-8.patch9.32 KBamateescu
#8 interdiff.txt1.54 KBamateescu
#6 2017139-6.patch9.34 KBamateescu
#2 2017139-do-not-test.patch10.05 KBswentel

Comments

swentel’s picture

swentel commented
Issue tags: +Field API

Tagging

swentel’s picture

swentel commented
StatusFileSize
new 2017139-do-not-test.patch10.05 KB

Initial patch, can't get it to save stuff though.

swentel’s picture

swentel commented

Note that default_token_formatter should go from the patch.

linclark’s picture

linclark commented

I think dates not saving could be an underlying problem. I've been running into the issue in a serialization patch.

These two lines of code should be the same (they are in the case of text fields), but they aren't behaving the same:

$entity->get($field_name)->offsetGet(0)->setValue(array('value' =>$iso_date));
$entity->get($field_name)->offsetGet(0)->get('value')->setValue($iso_date);

I had created #2019587: Add test coverage for DateTimeItem to add tests for that issue.

swentel’s picture

swentel commented
Status: Postponed » Active
amateescu’s picture

amateescu commented
Status: Active » Needs review
StatusFileSize
new 2017139-6.patch9.34 KB

Recreated the patch :)

Status: Needs review » Needs work

The last submitted patch, 2017139-6.patch, failed testing.

amateescu’s picture

amateescu commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.54 KB
new 2017139-8.patch9.32 KB

And this one should work.

yched’s picture

yched commented

This looks good, but I'd rather let #2051177: Make existing ConfigFieldItem subclasses usable by base fields get in first :-)

amateescu’s picture

amateescu commented
StatusFileSize
new interdiff.txt2.03 KB
new 2017139-10.patch9.26 KB

That one just got in, here's an updated patch.

yched’s picture

yched commented
Status: Needs review » Reviewed & tested by the community

Looks good. Thanks !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 362e5f8 and pushed to 8.x. Thanks!

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Convert field type to typed data plugin for datetime module » [Change notice] Convert field type to typed data plugin for datetime module
Priority: Normal » Critical
Status: Fixed » Active
Issue tags: +API change, +Needs change record, +Approved API change

Several API changes here that it took me a git bisect to find :)

xjm’s picture

xjm
she/her
Primary language English
commented
Title: [Change notice] Convert field type to typed data plugin for datetime module » Convert field type to typed data plugin for datetime module
Priority: Critical » Normal
Status: Active » Fixed
Issue tags: -API change, -Needs change record, -Approved API change

Never mind; these are just hook implementations. Sorry @beejeebus. :)

Status: Fixed » Closed (fixed)
Issue tags: +API change, +Needs change record, +Approved API change

Automatically closed -- issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: -Needs change record

Darn you d.o.