Convert system module's JsonUnitTest to phpunit

#1: system-json-2016299-01.patch queued for re-testing.

not sure if its worthy to convert those, since they ll probably die in favor of JsonResponse

Sure, fine by me!

+++ b/core/lib/Drupal/Component/Utility/Json.phpundefined
@@ -0,0 +1,37 @@
+class Json {
+  /**

needs a newline in between

+++ b/core/lib/Drupal/Component/Utility/Json.phpundefined
@@ -0,0 +1,37 @@
+  public static function encode($var) {
...
+  public static function decode($var) {

@param docs needed

+++ b/core/tests/Drupal/Tests/Component/Utility/JsonTest.phpundefined
@@ -2,21 +2,22 @@
+ * Definition of Drupal\Tests\Component\Utility\JsonTest.

Contains \Drupal\....

About the test: Maybe you could break it up to methods using dataProviders so we make it a bit more readable than now?

I am not convinced that data providers would improve the readability, but splitting it up would certainly help.

breaking it up that way works too:)
thanks!

Needs a reroll

curl https://drupal.org/files/drupal-2016299-7.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 10810  100 10810    0     0   9141      0  0:00:01  0:00:01 --:--:-- 11041
error: patch failed: core/includes/common.inc:1
error: core/includes/common.inc: patch does not apply

Just another rerole.

+++ b/sites/default/default.settings.phpundefined
@@ -289,9 +289,6 @@
- * - Note that this debugging markup will cause automated tests that directly
- *   check rendered HTML to fail. When running automated tests, 'twig_debug'
- *   should be set to FALSE.

irrelevant hunk?

Good catch!

awesome thanks!

#12: drupal-2016299-11.patch queued for re-testing.

back to rtbc

Committed/pushed to 8.x, thanks!