I stumbled across a @todo saying to remove some code once #1822458: Move dynamic parts (view modes, bundles) out of entity_info() was fixed. That issue is fixed, so here's that removal.

CommentFileSizeAuthor
#4 entity_bundle_info-no_alter-4.patch3.79 KBeffulgentsia
entity_bundle_info-no_alter.patch3.78 KBeffulgentsia

Comments

andypost’s picture

andypost
he/him
Primary language Russian
commented

where is the removal of @todo in a patch? looks nice clean-up

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community 
+++ b/core/modules/field/tests/modules/field_test/field_test.moduleundefined
@@ -269,20 +269,3 @@ function field_test_field_extra_fields_alter(&$info) {
- * @todo Remove when http://drupal.org/node/1822458 is fixed.

Right here.

I remember hitting that field_test_module_implements_alter() when converting this, I don't know why I didn't just remove it. Thanks @effulgentsia!
If it passes we're good here.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Needs a reroll...

curl https://drupal.org/files/entity_bundle_info-no_alter.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3873  100  3873    0     0   5063      0 --:--:-- --:--:-- --:--:--  6643
error: patch failed: core/modules/field/tests/modules/field_test/field_test.entity.inc:50
error: core/modules/field/tests/modules/field_test/field_test.entity.inc: patch does not apply
effulgentsia’s picture

effulgentsia commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs reroll
StatusFileSize
new entity_bundle_info-no_alter-4.patch3.79 KB

Straight reroll. Leaving at RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed bd6ad51 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.