merlinofchaos wrote a piece of code which makes it really easy to refresh the content of a view.

As many contrib modules already does that, these small change is totally fine.

CommentFileSizeAuthor
#6 drupal-2007474-6.patch847 bytesdawehner
#6 interdiff.txt797 bytesdawehner
#5 drupal-2007474-5.patch703 bytesdawehner
#1 views-2007474-1.patch627 bytesdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Project: Views (for Drupal 7) » Drupal core
Version: 7.x-3.x-dev » 8.x-dev
Component: Code » views.module
Status: Active » Patch (to be ported)
Issue tags: +VDC
StatusFileSize
new views-2007474-1.patch627 bytes

Committed and moved to the core issue queue.

amateescu’s picture

amateescu commented
Status: Patch (to be ported) » Needs review
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Patch (to be ported)

nope

amateescu’s picture

amateescu commented

Does the bot know that it has to test the 'patch (to be ported)' status?

dawehner’s picture

dawehner
Primary language German
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new drupal-2007474-5.patch703 bytes

This is the patch which got committed against Views 7.x-3.x

Let's port it.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new interdiff.txt797 bytes
new drupal-2007474-6.patch847 bytes

damian suggested to add some documentation.

dawehner’s picture

dawehner
Primary language German
commented

#6: drupal-2007474-6.patch queued for re-testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: Make it easy to refresh a view. » Make it easy to refresh a view
Issue tags: +JavaScript

Looks good to me, but I'm not 100% sure.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community

Pretty nifty patch. Right now because ajaxPageState is borked it makes errors all over the place but it's not because of this code.

It'd say it's good to go. I'm happy with that. It might looks wrong and/or backwards but that's just because of Drupal.ajax.

And if someone wants to test, make sure the ajax option of the view has been checked, won't work otherwise :p

dawehner’s picture

dawehner
Primary language German
commented
Category: feature » task

Moving to task as it is technical just a port from d7, so not a feature.

yesct’s picture

yesct commented
Issue tags: +RTBC July 1

This issue was RTBC and passing tests on July 1, the beginning of API freeze.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Confirmed that this is a port of a D7 feature...

Committed 9f4b810 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.