Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views.module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
24 May 2013 at 01:02 UTC
Updated:
29 Jul 2014 at 22:22 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
elvis2 commentedComment #2
elvis2 commentedComment #3
valthebaldExtra space in function get_aggregation_info() comment, otherwise looks fine
Comment #4
connorwk commentedI removed the extra spaces in-front of the comment.
Comment #5
valthebaldLooks fine for me, no more occurrences of add_signature() in core folder
Comment #6
oenie commentedAdd public access modifier in front of the function to adher to the new OOP standards.
Comment #7
valthebald@oenie, what was the reason to change issue status from RTBC?
Comment #8
oenie commented@valtthebald: as mentioned in my small review, we have to make sure that all methods are supplied with an access modifier.
See the META issue, comment #28.
Since we're doing these patches, we might as well make sure they get done as good as we can.
Comment #9
elvis2 commentedI added access modifier.
Comment #11
elvis2 commented#9: 2002280-9-rename-add_signature.patch queued for re-testing.
Comment #13
elvis2 commented#9: 2002280-9-rename-add_signature.patch queued for re-testing.
Comment #14
oenie commentedLooks good to me now !
Comment #15
alexpottCommitted b880d8f and pushed to 8.x. Thanks!