Remove backward compatible ControllerInterface

maybe as a first step, we should fix all references to the old controller to point to the new one, so people copying and pasting from elsewhere, use the new namespace and then after, as a second step remove the interface
this would ensure that a lot less patches break

here is the patch, same as #1 but without removing the controller

I like the second approach. Break as few patches as possible. (But then go review patches and tell them to change before they're RTBC.)

Er, no. Sorry. We should NOT change HtmlFormController et al yet, because we want existing RTBC patches to still work. We can change that when we remove the old interface outright, which is probably another week or two.

problem is that

in_array('Drupal\Core\ControllerInterface', class_implements($form_arg))

returns FALSE for classes using the new Drupal\Core\Controller\ControllerInterface
so here is a re-upload of #1

i think the more conversions are being commited this patch would need a reroll, as more usages are being added..so maybe postpone this, stick to the old interface for now and revisit before release, or when conversions are commited in a lot slower pace:P

Rerolled.

Tested below steps manually

1. applied batch and checked code base for Drupal\Core\ControllerInterface - No occurance
2. Re-installed drupal after patch - Installed without any error.

to me, it is RTBC :)

Setting RTBC.

Ok we either do not commit other conversions and commit this first or we keep rerolling..so addding tag..lets get this in asap

I fully agree with getting this in now. Learning the new ways of doing page callbacks is hard enough for D8 newcomers, so let's not trouble them even more by using a class that IDEs show as deprecated, while using the new one doesn't even work actually.

Needs reroll and bumping priority as two ways of doing stuff not good...

curl https://drupal.org/files/controller-1998140-19.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 29318  100 29318    0     0  21389      0  0:00:01  0:00:01 --:--:-- 24803
error: patch failed: core/modules/aggregator/lib/Drupal/aggregator/Routing/AggregatorController.php:9
error: core/modules/aggregator/lib/Drupal/aggregator/Routing/AggregatorController.php: patch does not apply
error: patch failed: core/modules/config/lib/Drupal/config/Controller/ConfigController.php:7
error: core/modules/config/lib/Drupal/config/Controller/ConfigController.php: patch does not apply
error: patch failed: core/modules/field_ui/lib/Drupal/field_ui/Form/FieldInstanceEditForm.php:8
error: core/modules/field_ui/lib/Drupal/field_ui/Form/FieldInstanceEditForm.php: patch does not apply
error: patch failed: core/modules/field_ui/lib/Drupal/field_ui/Form/FieldWidgetTypeForm.php:8
error: core/modules/field_ui/lib/Drupal/field_ui/Form/FieldWidgetTypeForm.php: patch does not apply
error: patch failed: core/modules/field_ui/lib/Drupal/field_ui/OverviewBase.php:9
error: core/modules/field_ui/lib/Drupal/field_ui/OverviewBase.php: patch does not apply

reroll

#25: controller-1998140-25.patch queued for re-testing.

Committed 07bf168 and pushed to 8.x. Thanks!

Need to update at least one change record https://drupal.org/node/1800686

Change notice updated.

Removing no longer needed tag.