Blocked on #1979784: Factor Create.js and VIE.js out of the Edit module.

  • Rename data-edit-id to data-edit-field-id
  • Rename data-edit-entity to data-edit-entity-id
  • Rename AppModel's (highlighted|active)Editor to (highlighted|active)Field
  • Rename the 'direct' editor to 'plaintext' editor.
  • Rename FieldToolbarView to EditedElementToolbarView.
  • Rename EditorDecorationView to EditedElementDecorationView.
  • drupalSettings.edit.(metadataURL|fieldFormURL) should not pass full URLs. The JS should use Drupal.url('some/path') instead.
  • Consistently name in-place editors, both in terms of library names as in terms of filenames.

(Should be updated/extended until we get to this.)

Comments

wim leers’s picture

Issue summary: View changes

Updated issue summary.

wim leers’s picture

Issue summary: View changes

Updated issue summary.

wim leers’s picture

Issue summary: View changes

Updated issue summary.

wim leers’s picture

Issue summary: View changes

Updated issue summary.

wim leers’s picture

Issue summary: View changes

Updated issue summary.

wim leers’s picture

Issue tags: +sprint

.

wim leers’s picture

Assigned: Unassigned » wim leers
Status: Postponed » Active

#1979784: Factor Create.js and VIE.js out of the Edit module got committed, we can now work on this. I'll work on this after DrupalCon.

wim leers’s picture

This is now blocked on #1678002: Edit should provide a usable entity-level toolbar for saving fields. We don't want to reroll that issue for minor things like this.

wim leers’s picture

I split off "Make sure Edit works at all when a same entity exists multiple times on the same page (possibly in a different view mode). Also: all instances of the same entity on the same page should be updated when one of them is modified." to another issue: #2075185: When an entity is in-place edited (i.e. saved), other instances of that entity on the same page are not updated (no propagation).

wim leers’s picture

Issue summary: View changes

Updated issue summary.

wim leers’s picture

Issue tags: -sprint

We're not fixing this in the current sprint.

wim leers’s picture

Issue summary: View changes

Split off an important part to https://drupal.org/node/2075185.

wim leers’s picture

Issue summary: View changes
wim leers’s picture

wim leers’s picture

wim leers’s picture

Status: Active » Closed (fixed)

All done now! Closing :)