Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of #1971384: [META] Convert page callbacks to controllers
For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.
Comment | File | Size | Author |
---|---|---|---|
#9 | drupal-1978978-8.patch | 9.77 KB | dawehner |
#9 | interdiff.txt | 1.81 KB | dawehner |
#5 | controller-1978978-5.patch | 10.64 KB | ParisLiakos |
#2 | controller-1978978-2.patch | 7.79 KB | plopesc |
#2 | interdiff.txt | 1.86 KB | plopesc |
Comments
Comment #1
plopescHello
Attaching patch that converts simpletest_test_form() to a Controller.
Regards
Comment #2
plopescRe-rolling improved patch.
Regards.
Comment #3
ParisLiakos CreditAttribution: ParisLiakos commentedhi! Great job, thanks!
i think its good to go:)
Comment #4
ParisLiakos CreditAttribution: ParisLiakos commented#1978982: Convert simpletest_result_form to a Controller was committed first, so now we need to fix the @todo there
Comment #5
ParisLiakos CreditAttribution: ParisLiakos commentedhere it is
Comment #6
dawehnerGreat!
Comment #7
alexpottI'm not sure that this is the right thing to do... and might turn out to be quite brittle... this kind of implies that the
SimpletestResultsForm
is a special case of theSimpletestTestForm
and can share validator's etc... I don't think this is the case. For instance, if for whatever reason we add validation toSimpletestTestForm
... then we'll have to add an emptyvalidateForm()
method toSimpletestResultsForm
I think in
SimpletestResultsForm::submitForm()
we should create a new instance ofSimpletestTestForm
and submit it.Comment #8
Crell CreditAttribution: Crell commentedI'm inclined to agree with Alex. This doesn't strike me as a "is a special case of" relationship.
Comment #9
dawehnerThat's indeed a good idea. Do you think this comment describes what we are doing?
Comment #10
alexpottYep comment looks good to me... will leave for someone else to rtbc so I can commit :)
Comment #11
Crell CreditAttribution: Crell commentedGet with the committing, dude!
Comment #12
alexpottCommitted b8ddc39 and pushed to 8.x. Thanks!