Update hook_help Ban module

In the current D8 dev version, a help text is displayed, but the configuration link just links to /admin/config/people - without any configuration for ban available.

Let's combine the first two sentences into a single paragraph, as in our hook_help standard.

Also, this patch should not remove the blank line here:

       return $output;
-

Other than that, and assuming someone has verified that the links work, I think it looks good!

That is a great idea. However, you can still make it part of the same paragraph... Ah, you did that here in your patch. Good! :)

Do you want to update the "how to create help" standards page with this formatting suggestion so people can continue to use the template there as a starting point?

Anyway, assuming this turns green, I think it's fine. I will wait to mark it "RTBC" until someone besides batigolix has verified the links work, since the first reviewer says they didn't work. Whoever is reviewing: start with a clean D8 installation and make sure the Ban module is enabled.

I've tested the patch in #7 on a clean 8.x-dev version.
Both links work and the text makes sense to me.

Thanks for testing! In that case let's mark it RTBC. I think the "needs work" status change in #11 was a mistake.

This issue was RTBC and passing tests on July 1, the beginning of API freeze.

In light of our discussion on other Help issues, let's fix the reference to the online documentation. I think the people working on this issue know what to do...

style

I think the text inside the A tags (the link text) should be "the online documentation for the Ban module" right?

Yeah, the link should be (link)online documentation for the Ban module(endlink) and the URL should also be https.

OK, good!

Does this need a Uses section with a link to the admin page where this banning can be done and a brief explanation of how to do it?

Doh! That Uses section is already there. :)

OK, I think this one is ready to be committed. It just adds the required link to the online docs.

The link was to a handbook page that didn't exist - I've changed it to the documentation page.
Remove trailing whitespace.

Doh! Good catch. RTBC again...

Thanks all! Committed to 8.x.

diff --git a/core/modules/ban/ban.module b/core/modules/ban/ban.module
old mode 100644
new mode 100755

needs followup for this

This already seem to be fixed in the current 8.x version.

Agreed. I just did a git pull on 8.x and the permissions are correct for all the files in core/modules/ban.

Created follow up for #25 at #2055865: Revert file permission of ban.module file from 100755 back to 100644 and removing corresponding tag.

add link