Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Created as a result of the discussion in #1898054-57: comment.module - Convert PHPTemplate templates to Twig.
There are still two calls to theme() in template_preprocess_comment() that have not been converted to render arrays as part of the Twig conversion. This is because changing them causes test failures, and the concern is that there may be other failures elsewhere that are out of the scope of the Twig conversion process.
This is a separate issue for removing the final uses of theme() in the comment preprocess functions once the conversion has been committed.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | comment-remove-theme-1972702-2.patch | 28.22 KB | shanethehat |
Comments
Comment #1
shanethehat commentedI'll build a patch based on #1898054-61: comment.module - Convert PHPTemplate templates to Twig to see how many test fails we're looking at.
Comment #2
shanethehat commentedPatch includes #1898054-61: comment.module - Convert PHPTemplate templates to Twig
Comment #3
thedavidmeister commentedtagging so we don't lose this.
Comment #5
shanethehat commentedSeems like the only tests that fail are part of the comment module.
Comment #6
joelpittetThis was fixed in #2008980: Replace theme() with drupal_render() in comment module
Comment #6.0
joelpittetfix typo