Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
config.module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
16 Apr 2013 at 09:01 UTC
Updated:
29 Jul 2014 at 22:10 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
wim leersTypo fix :)
Comment #2
wim leersThis is not specific to editor.module, it really is a CMI module. Best-effort recategorization.
Comment #3
alexpottComment #4
balagan commentedI already cannot find any label: 'Langcode' occurances, carrying on checking label: 'Language'
Comment #5
balagan commentedThere was only one occurance that I could find on the UI, I have changed that to 'Default language'.
Comment #6
balagan commentedComment #7
balagan commentedI have just realized that I have changed a wrong entry (not a langcode). Now I have changed all the other occurances to Default language. Also did a search for 'Language code', there was only 1 of it.
Comment #9
gábor hojtsy7: 1971490-2.patch queued for re-testing.
Comment #11
balagan commented7: 1971490-2.patch queued for re-testing.
Comment #12
yesct commentedI think we made an effort to have the label in the schemas to match what the UI labels are.
I'm not sure we should now change the schemas... without also standardizing what the UI has.
Comment #13
gábor hojtsyComment #14
yesct commentedI agree. If these are ones that never show in the UI, then making them consistent is a very good idea.
Comment #15
vijaycs85looks good to me, but we might not covered all schema files.
Comment #16
balagan commentedI check it again
Comment #17
balagan commentedSorry, I have missed the block.schema.yml file. Enclosed a new patch.
Now there should not be any more *schema.yml file with label: 'language', label: 'language code' and label: 'langcode' strings, all were changed to label: 'Default language'
Comment #18
gábor hojtsyLooks good as per above :)
Comment #19
vijaycs85just doubled checked all schema files and seems the patch in #17 covering all of them (we got 26 instance except those 7 in patch, all of them already got 'Default language'). So +1 for RTBC.
Comment #20
webchickNice clean-up.
Committed and pushed to 8.x. Thanks!