From #1957148: Replace entity_query() with Drupal::entityQuery() we should remove this helper function, and I think add a Drupal::entityQueryAggregate() method instead, as I think this will be a. consistent with entityQuery and b. used enough to earn a spot in the Drupal class.

CommentFileSizeAuthor
d8.drupal-eqa.patch1.93 KBdamiankloip

Comments

Status: Needs review » Needs work

The last submitted patch, d8.drupal-eqa.patch, failed testing.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review

d8.drupal-eqa.patch queued for re-testing.

Got to love a random test failure...

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Great. Let's get it removed as fast as possible.

dawehner’s picture

dawehner
Primary language German
commented

Well to be honest I don't think it's used that often that we even need a wrapper in the Drupal class?

damiankloip’s picture

damiankloip commented

I think it makes things consistent. Keeping the api similar for both types of entity query I think is a good thing. We don't lose anything having it in the Drupal class. flood() is in there, that's not used too often :)

chx’s picture

chx commented

I do not care one way or another.

xjm’s picture

xjm
she/her
Primary language English
commented

d8.drupal-eqa.patch queued for re-testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs review

Same deal as #1957148-17: Replace entity_query() with Drupal::entityQuery(). In fact, can we please combine these two issues since they do exactly the same thing, more or less?

damiankloip’s picture

damiankloip commented
Status: Needs review » Closed (duplicate)