Update file permissions

these changes look good on first glace.

Lets do a fancy unix command to see if we missed any.

before the patch:

535 $ find . -type f -perm -00755 | grep -v ".git"
./core/misc/ui/themes/base/images/ui-bg_flat_0_aaaaaa_40x100.png
./core/misc/ui/themes/base/images/ui-bg_glass_55_fbf9ee_1x400.png
./core/misc/ui/themes/base/images/ui-bg_glass_65_ffffff_1x400.png
./core/misc/ui/themes/base/images/ui-bg_glass_75_dadada_1x400.png
./core/misc/ui/themes/base/images/ui-bg_glass_75_e6e6e6_1x400.png
./core/misc/ui/themes/base/images/ui-bg_highlight-soft_75_cccccc_1x100.png
./core/misc/ui/themes/base/images/ui-icons_222222_256x240.png
./core/misc/ui/themes/base/images/ui-icons_2e83ff_256x240.png
./core/misc/ui/themes/base/images/ui-icons_454545_256x240.png
./core/misc/ui/themes/base/images/ui-icons_888888_256x240.png
./core/misc/ui/themes/base/images/ui-icons_cd0a0a_256x240.png
./core/modules/locale/locale.fetch.inc
./core/modules/views/tests/views_test_config/test_views/views.view.test_dropbutton.yml
./core/scripts/drupal.sh
./core/scripts/password-hash.sh
./core/scripts/run-tests.sh
./core/vendor/phpunit/phpunit/composer/bin/phpunit
./core/vendor/symfony/process/Symfony/Component/Process/Exception/ExceptionInterface.php
./core/vendor/symfony/process/Symfony/Component/Process/Exception/ProcessFailedException.php
./core/vendor/symfony/process/Symfony/Component/Process/Exception/RuntimeException.php
[~/foo/d8-git]
02:33 PM [YesCT]  (8.x) 
536 $ find . -type f -perm -00755 | grep -v ".git" | wc -l
      20

tried drush am:

$ drush am 1948148
Drush iq-apply-patch 1948148-0: downloading patchfile file-permissions.patch for project drupal  [ok]
Switching to branch drush-iq-update-file-permissions-1948148-0                                   [ok]
Branch drush-iq-update-file-permissions-1948148-0 set up to track remote branch 8.x from origin.
Switched to a new branch 'drush-iq-update-file-permissions-1948148-0'
patch: **** Only garbage was found in the patch input.
patch: **** Only garbage was found in the patch input.
Could not apply the patch with either -Np0 or -Np1; perhaps the patch was rolled for a different [error]
version of the project.

doing it manually:

$ curl -O http://drupal.org/files/file-permissions.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3350  100  3350    0     0  15070      0 --:--:-- --:--:-- --:--:-- 22483
[~/foo/drupal]
02:35 PM [YesCT]  (drush-iq-update-file-permissions-1948148-0) 
733 $ git apply --index file-permissions.patch
[~/foo/drupal]
02:35 PM [YesCT]  (drush-iq-update-file-permissions-1948148-0) 

after the patch:

734 $ git status
# On branch drush-iq-update-file-permissions-1948148-0
# Changes to be committed:
#   (use "git reset HEAD <file>..." to unstage)
#
#	modified:   core/misc/ui/themes/base/images/ui-bg_flat_0_aaaaaa_40x100.png
#	modified:   core/misc/ui/themes/base/images/ui-bg_glass_55_fbf9ee_1x400.png
#	modified:   core/misc/ui/themes/base/images/ui-bg_glass_65_ffffff_1x400.png
#	modified:   core/misc/ui/themes/base/images/ui-bg_glass_75_dadada_1x400.png
#	modified:   core/misc/ui/themes/base/images/ui-bg_glass_75_e6e6e6_1x400.png
#	modified:   core/misc/ui/themes/base/images/ui-bg_highlight-soft_75_cccccc_1x100.png
#	modified:   core/misc/ui/themes/base/images/ui-icons_222222_256x240.png
#	modified:   core/misc/ui/themes/base/images/ui-icons_2e83ff_256x240.png
#	modified:   core/misc/ui/themes/base/images/ui-icons_454545_256x240.png
#	modified:   core/misc/ui/themes/base/images/ui-icons_888888_256x240.png
#	modified:   core/misc/ui/themes/base/images/ui-icons_cd0a0a_256x240.png
#	modified:   core/modules/locale/locale.fetch.inc
#	modified:   core/modules/views/tests/views_test_config/test_views/views.view.test_dropbutton.yml
#	modified:   core/scripts/drupal.sh
#	modified:   core/scripts/password-hash.sh
#	modified:   core/scripts/run-tests.sh
#	modified:   core/vendor/phpunit/phpunit/composer/bin/phpunit
#	modified:   core/vendor/symfony/process/Symfony/Component/Process/Exception/ExceptionInterface.php
#	modified:   core/vendor/symfony/process/Symfony/Component/Process/Exception/ProcessFailedException.php
#	modified:   core/vendor/symfony/process/Symfony/Component/Process/Exception/RuntimeException.php
#
[~/foo/drupal]
02:36 PM [YesCT]  (drush-iq-update-file-permissions-1948148-0) 
735 $ find . -type f -perm -00755 | grep -v ".git" | wc -l
       0
[~/foo/drupal]
02:36 PM [YesCT]  (drush-iq-update-file-permissions-1948148-0) 
736 $ find . -type f -perm -00755 | grep -v ".git" 
[~/foo/drupal]
02:37 PM [YesCT]  (drush-iq-update-file-permissions-1948148-0) 
737 $ 

rtbc to me.

file-permissions.patch queued for re-testing.

Ressin' fressin #2.

I'd love to figure out how not to do this. :\

In the meantime, committed and pushed to 8.x. Thanks!

 mode change 100755 => 100644 core/scripts/drupal.sh
 mode change 100755 => 100644 core/scripts/password-hash.sh
 mode change 100755 => 100644 core/scripts/run-tests.sh

i am curious how tests run..those are scripts, the are supposed to be executable

 mode change 100755 => 100644 core/vendor/symfony/process/Symfony/Component/Process/Exception/ExceptionInterface.php
 mode change 100755 => 100644 core/vendor/symfony/process/Symfony/Component/Process/Exception/ProcessFailedException.php
 mode change 100755 => 100644 core/vendor/symfony/process/Symfony/Component/Process/Exception/RuntimeException.php

leave core/vendor/* directory out;) we should open PR to fix those

mode change 100755 => 100644 core/vendor/phpunit/phpunit/composer/bin/phpunit
This is executable too

Yeah, I'm confused, aren't these the same changes that were discussed (but then not implemented) in #1841896: Fix various file permissions?

Although the upstream ones were apparently already fixed upstream; not sure if that means it's time to pull them in or not.

Wow, totally missed the changes to the scripts.

run-tests.sh isn't a shell script, despite the name; you run it with php. So maybe that's the difference? But yeah, it confuses me that those were included here.

btw those jquery ui icons should not be touched as well, it is vendor code:)
so basically, revert the commit?

those are the only files that should be changed

./core/modules/locale/locale.fetch.inc
./core/modules/views/tests/views_test_config/test_views/views.view.test_dropbutton.yml

Ha, ok then. :)

git revert 13b929b667

FYI: Per #1841896-10: Fix various file permissions, the jQuery UI files were fixed upstream.

no need to apologize, thank you for your work no matter if it was duplicate, we all been there

added duplicate/overlap/related issues

there is already #2401919: Fix various file permissions to be 644