Tested latest D6 version from today and i have one module and one theme on my box that are not yet projects on d.o. To verify this i moved the local module out of this install and half of the error lines are gone.

This are the errors of shown in update module when non d.o modules are checked for update status:

    * notice: Undefined index: meta in C:\Inetpub\wwwroot\drupal6\modules\update\update.fetch.inc on line 205.
    * notice: Undefined index: link in C:\Inetpub\wwwroot\drupal6\modules\update\update.fetch.inc on line 205.
    * notice: Undefined index: script in C:\Inetpub\wwwroot\drupal6\modules\update\update.fetch.inc on line 205.
    * notice: Undefined index: in C:\Inetpub\wwwroot\drupal6\modules\update\update.fetch.inc on line 205.
    * notice: Undefined index: img in C:\Inetpub\wwwroot\drupal6\modules\update\update.fetch.inc on line 205.
    * notice: Undefined index: input in C:\Inetpub\wwwroot\drupal6\modules\update\update.fetch.inc on line 205.
    * notice: Undefined index: meta in C:\Inetpub\wwwroot\drupal6\modules\update\update.fetch.inc on line 205.
    * notice: Undefined index: link in C:\Inetpub\wwwroot\drupal6\modules\update\update.fetch.inc on line 205.
    * notice: Undefined index: script in C:\Inetpub\wwwroot\drupal6\modules\update\update.fetch.inc on line 205.
    * notice: Undefined index: in C:\Inetpub\wwwroot\drupal6\modules\update\update.fetch.inc on line 205.
    * notice: Undefined index: img in C:\Inetpub\wwwroot\drupal6\modules\update\update.fetch.inc on line 205.
    * notice: Undefined index: input in C:\Inetpub\wwwroot\drupal6\modules\update\update.fetch.inc on line 205.
CommentFileSizeAuthor
#7 notices.patch672 byteschx

Comments

theborg’s picture

theborg commented
Status: Active » Postponed (maintainer needs more info)

Did you disabled the module before moving the files?

hass’s picture

hass commented
Status: Postponed (maintainer needs more info) » Active

Tried disabling the module and this will reduce the error lines, too. Update module only checks active modules...

Additional please don't forget if i download a theme let's say "zen" and rename this to "mycompanytheme" for customizations and do an update check i get this errors... very simple repro case.

chx’s picture

chx commented
Priority: Critical » Minor

This is why we must shp w/ E_ALL off -- people see the most harmless notices and scream critical because they think they are errors.

hass’s picture

hass commented

D6 will not E_ALL compliant? I thought this is one of the big features in D6... aside - older DEV releases haven't had this bugs!

hass’s picture

hass commented
Title: beta 3 breaker: "Undefined index" errors with modules/themes not on d.o » E_ALL: "Undefined index" errors with modules/themes not on d.o
hass’s picture

hass commented
Priority: Minor » Critical

I checked my PHP config and nevertheless i have configured: error_reporting = E_ALL & ~E_NOTICE

I get this listed as errors in RED. Marking back as critical to get the drupal_set_message "error" message fixed for final.

chx’s picture

chx commented
Status: Active » Reviewed & tested by the community
StatusFileSize
new notices.patch672 bytes
hass’s picture

hass commented

@chx: Thank you, this fixes the notices for me.

dww’s picture

dww
we/he/they
commented
Priority: Critical » Normal

Please.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Needs work

hass: It is not a priority for Drupal 6 to fix all possible E_ALL errors, we can fix. We do fix all possible E_ALL errors we encounter, but being a dynamic system, such errors can and will pop up even in Drupal core for quite some time. Also because we would not like to stop contributed modules and themes from flourishing, we are nor displaying E_NOTICE errors in Drupal releases (even in betas and RC1 this was the same way, just look back). So we keep the tradition of all previous releases of not shipping Drupal with E_ALL, but we improved through this release to solve many of the E_ALL problems. We still need to solve more in core, but that will not hold back the release (hence, not critical), and contrib modules and themes will need to improve in their own areas.

On the patch: the issue at hand is that we have projects not hosted on the default project home (which is used when update module does not find a specified projcet home in the info file). So instead of the project info XML, we get a different result back. Now why should we handle this in the end tag handler code? Shouldn't this be detected and stopped much earlier?

hass’s picture

hass commented

I thought D6 will be the first E_ALL compliant release, but ok. I only complained about the drupal_set_message errors, displayed on my site. And i have error_reporting = E_ALL & ~E_NOTICE - not E_ALL only. I'm not sure why this popup as error, but it looks like something core does and not me.

I don't know what will be the best way, but we should stop this or all people customizing a theme will get this errors, not to mention some non d.o hosted and internal or special business modules nobody else have in use.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

hass: Drupal itself sets E_ALL (regardless of your PHP setup) in the development versions, so we can catch and fix these types of errors. In the release versions, Drupal sets E_ALL & ~E_NOTICE again regardles of your PHP setup, so these kinds of minor errors are not bothering users. So we should fix this if possible, but that does not make it critical.

hass’s picture

hass commented

Ah, thank you... i was not aware about this development only setting.

dww’s picture

dww
we/he/they
commented
Category: bug » support
Status: Needs work » Closed (fixed)

I just tried and failed to reproduce this "bug". I made some bogus local modules and themes with valid .info files (defining name, project, version, etc, as needed by update.module), and enabled them. None of these exist on drupal.org. I manually fetched available update data, reloaded the available updates report, status report, etc. No notice warnings at all. I also verified I'm using the -dev version of core with E_ALL on, so, if there were any warnings, I'd see them.

hass’s picture

hass commented
Category: support » bug
Status: Closed (fixed) » Fixed

This bug was inside and may be fixed by a different patch in the meantime, but it was there for sure. chx verified this, too.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

fuzzy76’s picture

fuzzy76 commented

Got bitten by this while trying to get a D6 site in shape for an upgrade. I guess wontfix is more accurate by now...