ViewsStorageController::postSave should be protected [#1938680]

Comment	File	Size	Author
#2	protect_views_postSave-1938680-2.patch	703 bytes	toastieAlex

Comment #1

dawehner

German

commented 11 March 2013 at 20:54

Component:

comment.module

» views.module

Yeah simply novice tasks.

Log in or register to post comments

Comment #2

toastieAlex commented 12 March 2013 at 03:35

Status:

Active

» Needs review

Status	File	Size
new	protect_views_postSave-1938680-2.patch	703 bytes

Simply taking care of novice tasks.

Log in or register to post comments

Comment #3

tstoeckler

he/him

German

Essen, Germany

commented 12 March 2013 at 13:06

Status:

Needs review

» Reviewed & tested by the community

Awesome!

Log in or register to post comments

Comment #4

damiankloip commented 13 March 2013 at 11:59

Should we add the leading '\' in the docblock too?

Log in or register to post comments

Comment #5

tstoeckler

he/him

German

Essen, Germany

commented 15 March 2013 at 15:39

In fact that should either be
\Drupal\Config\ConfigStorageController::postSave()
or simply
ConfigStorageController::postSave()
As far as I'm aware we still haven't resolved that discussion. I usually prefer the latter, but I'll defer that to the patch-creator.

Log in or register to post comments

Comment #6

toastieAlex commented 15 March 2013 at 18:43

Assigned:

Unassigned

» toastieAlex

All the docblocks are the same, so I should update all or none of them. Seems like updating the documentation is a separate issue from changing access on a method.