Add convenience methods to EntityManager [#1931894]

As a half way house between deprecating entity procedural functions, maybe we could have some convenience methods on the entity manager as shortcuts for creating and loading entities?

So :

drupal_container()->get('plugin.manager.entity')->getStorageController('user')->create(array('value' => 'dfdfd'));

would become :

drupal_container()->get('plugin.manager.entity')->createEntity('user', array('value' => 'dfdfd'));

I'm not going to do any more on this for now, as the idea might just get shot down.

Comment	File	Size	Author
#2	1931894-2.patch	5.38 KB	damiankloip
#2	interdiff-1931894-2.txt	3.67 KB	damiankloip
	d8.entity-manager-methods.patch	2.58 KB	damiankloip

Comments

Comment #0.0

damiankloip commented 2 March 2013 at 14:10

Issue summary:

View changes

code block

Comment #1

dawehner

German

commented 23 May 2013 at 19:51

We probably want loadEntity and loadEntities.

Comment #2

damiankloip commented 23 May 2013 at 20:54

Status	File	Size
new	interdiff-1931894-2.txt	3.67 KB
new	1931894-2.patch	5.38 KB

Comment #3

dawehner

German

commented 8 June 2013 at 08:03

Status:

Needs review

» Reviewed & tested by the community

Nice, thought we should be clear that it's still encouraged to use the storage controller directly.

Comment #4

alexpott

he/they

English

🇪🇺🌍

commented 17 June 2013 at 21:22

Status:

Reviewed & tested by the community

» Closed (won't fix)

Discussed this with @timplunkett and since #1893772: Move entity-type specific storage logic into entity classes and the improved typehints on storage controllers this would be a step back on properly injected code.

So... marking as "won't fix"... if @damiankloip or @dawehner feel this is wrong... re-open and explain... if we decide to kill all the entity_* wrappers then this will probably be a good compromise...

Comment #5

damiankloip commented 22 June 2013 at 12:44

I would have at least postponed it on that basis, for review before release. I was under the impression that the entity_* wrappers were going, so IMO we need something like this instead.