Fix views rest export plugin render values and add option to output raw values

Nice work!

+++ b/core/modules/rest/lib/Drupal/rest/Plugin/views/row/DataFieldRow.phpundefined
@@ -41,14 +41,25 @@ class DataFieldRow extends RowPluginBase {
+  protected $rawOutput = array();

What about simply rawOutputOptions?

+++ b/core/modules/rest/lib/Drupal/rest/Plugin/views/row/DataFieldRow.phpundefined
@@ -41,14 +41,25 @@ class DataFieldRow extends RowPluginBase {
+      $aliases = static::extractFromOptionsArray('alias', $options);

Nice method!

+++ b/core/modules/rest/lib/Drupal/rest/Plugin/views/row/DataFieldRow.phpundefined
@@ -116,14 +137,14 @@ public function render($row) {
+        $value = $field->sanitizeValue($row->{$field->field_alias}, 'xss_admin');

I'm totally fine with making sanitizeValue a public method.

Additional you probably want to use $field->getValue ?

+++ b/core/modules/rest/lib/Drupal/rest/Plugin/views/row/DataFieldRow.phpundefined
@@ -149,4 +170,21 @@ public function getFieldKeyAlias($id) {
+  public static function extractFromOptionsArray($key, $options) {

I'm wondering whether this should be protected instead? I don't see so much use-case for other people here?

+++ b/core/modules/rest/lib/Drupal/rest/Tests/Views/StyleSerializerTest.phpundefined
@@ -211,4 +199,30 @@ public function testUIFieldAlias() {
+    $row_options = 'admin/structure/views/nojs/display/test_serializer_display_field/rest_export_1/row_options';
...
+    $view->setDisplay('ws_endpoint_1');

Is there a reason why we use two different displays (rest_export_1 for the UI and ws_endpoint_1 for the test?)

+++ b/core/modules/rest/lib/Drupal/rest/Tests/Views/StyleSerializerTest.phpundefined
@@ -211,4 +199,30 @@ public function testUIFieldAlias() {
+    $this->drupalPost($row_options, array('row_options[field_options][created][raw_output]' => '1'), t('Apply'));

Oh good to know that you actually want to have that option on the row plugin?

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -458,6 +458,7 @@ protected function defineOptions() {
+    $options['raw_output'] = array('default' => TRUE);

Can't we still have that option on the row plugin? It feels a lot like that would confuse people. Additional, can you think of use-cases where you really want to have this behavior, as the user don't have any clue what the "raw" output could be, and even worse, we probably can't provide one for fieldapi fields. I'm sorry this changed was probably not intendend

There are just these two small issues.

+++ b/core/modules/rest/lib/Drupal/rest/Tests/Views/StyleSerializerTest.phpundefined
@@ -211,4 +199,30 @@ public function testUIFieldAlias() {
+      $this->assertIdentical($values['created'], $view->result[$index]->views_test_data_created, format_string('Expected raw created value found.'));

Any reason to use format_string without variables? In general I'm wondering whether it really makes sense to compare against $view->result or should better just do one single $this->assertEqual($this->drupalGetAJAX() ... , $expected))

+++ b/core/modules/rest/lib/Drupal/rest/Plugin/views/row/DataFieldRow.phpundefined
@@ -116,14 +137,14 @@ public function render($row) {
+      // If this is not unknown and the raw output option has been set, just
+      // get the raw value.

We can put the "get" into the previous line.

+++ b/core/modules/rest/lib/Drupal/rest/Tests/Views/StyleSerializerTest.phpundefined
@@ -211,4 +199,30 @@ public function testUIFieldAlias() {
+      $this->assertIdentical($values['created'], $view->result[$index]->views_test_data_created, format_string('Expected raw created value found.'));

Any reason to use format_string without variables? In general I'm wondering whether it really makes sense to compare against $view->result or should better just do one single $this->assertEqual($this->drupalGetAJAX() ... , $expected))

Nice refactoring and better and more tests, nice!

#9: 1929014-9.patch queued for re-testing.

+++ b/core/modules/rest/lib/Drupal/rest/Plugin/views/row/DataFieldRow.phpundefined
@@ -149,4 +170,21 @@ public function getFieldKeyAlias($id) {
+  protected static function extractFromOptionsArray($key, $options) {
+    return array_map(function($item) use ($key) {
+      return array_key_exists($key, $item) ? $item[$key] : NULL;
+    }, $options);

Can't this be isset()? If the array value is NULL, it'll end up returning NULL either way.

+++ b/core/modules/rest/lib/Drupal/rest/Plugin/views/row/DataFieldRow.phpundefined
@@ -183,7 +183,7 @@ public function getFieldKeyAlias($id) {
+      return isset($key, $item) ? $item[$key] : NULL;

I don't think this is the right code :) Shouldn't it be isset($item[$key])?

Well in fact isset($a, $b, $c) works, oh php :)

Thanks! Committed/pushed to 8.x.