Follow-up to: #501428: Date and time field type in core

Contrib to core upgrade paths are handled in contrib.

This code would be executed permanently whenever datetime module is installed on every single site and installation for the next 6+ years.

CommentFileSizeAuthor
drupal8.datetime-install.0.patch934 bytessun

Comments

swentel’s picture

swentel commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Yeah, I think this is right. It's one thing to put workaround code in hook_update_N() (which, while uncommon, is not entirely unprecedented; we've done it for Actions module in D6, for example), but we shouldn't be putting this kind of code in places that run on new sites.

In this case, seems like something DateTime module in contrib should be taking care of itself, so...

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.