Change test group of entity reference SelectionTest

This can live with other views module tests, but definitely not in the 'Views' group. This should be in 'Views Modules' if anywhere.

Comment	File	Size	Author
#3	1911688-3.patch	803 bytes	damiankloip
	db.er-selection-views-test.patch	700 bytes	damiankloip

Comments

Comment #1

damiankloip commented 8 February 2013 at 12:06

Status:

Active

» Needs review

Log in or register to post comments

Comment #2

amateescu commented 8 February 2013 at 13:46

Status:

Needs review

» Reviewed & tested by the community

I'm completely fine with that :)

Log in or register to post comments

Comment #3

damiankloip commented 8 February 2013 at 13:48

Status	File	Size
new	1911688-3.patch	803 bytes

Thanks, let's just change the label too, to match the other module test labels. i.e. "module: test name".

Log in or register to post comments

Comment #4

amateescu commented 8 February 2013 at 13:50

Label looks good as well.

Log in or register to post comments

Comment #5

8 February 2013 at 14:40

Status:

Reviewed & tested by the community

» Needs work

The last submitted patch, 1911688-3.patch, failed testing.

Log in or register to post comments

Comment #6

damiankloip commented 8 February 2013 at 15:08

Great, CKEditor has joined the random test failure party too.

Log in or register to post comments

Comment #7

damiankloip commented 8 February 2013 at 15:08

Status:	Needs work	» Needs review
Issue tags:	-VDC

#3: 1911688-3.patch queued for re-testing.

Log in or register to post comments

Comment #8

8 February 2013 at 15:56

Status:	Needs review	» Needs work
Issue tags:		+VDC

The last submitted patch, 1911688-3.patch, failed testing.

Log in or register to post comments

Comment #9

amateescu commented 8 February 2013 at 16:06

Status:

Needs work

» Reviewed & tested by the community

Yeah, nevermind that stupid random failure, the patch is still RTBC.

Log in or register to post comments

webchick’s picture

Comment #10

she/they

English

Vancouver 🇨🇦

commented 9 February 2013 at 11:57

Committed and pushed to 8.x. Thanks!

However, looking at that screen, "Views Modules" is a weird name for this grouping. Could we get a follow-up to rename that to something else, like maybe "Views Module Integration" or similar?

Log in or register to post comments

webchick’s picture

Comment #11

she/they

English

Vancouver 🇨🇦

commented 9 February 2013 at 11:57

Status:

Reviewed & tested by the community

» Fixed

Log in or register to post comments

Comment #12

damiankloip commented 9 February 2013 at 12:04

Sure thing, I just created #1912748: Rename ' Views Modules' test group. Which makes a good novice task.

Log in or register to post comments

Comment #13

23 February 2013 at 12:10

Automatically closed -- issue fixed for 2 weeks with no activity.

Log in or register to post comments